use env markers for version specific deps #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1679 +/- ##
==========================================
- Coverage 66.94% 66.94% -0.01%
==========================================
Files 144 144
Lines 17809 17809
==========================================
- Hits 11923 11922 -1
- Misses 5886 5887 +1 |
Codecov Report
@@ Coverage Diff @@
## master #1679 +/- ##
==========================================
+ Coverage 66.94% 66.95% +<.01%
==========================================
Files 144 144
Lines 17809 17810 +1
==========================================
+ Hits 11923 11924 +1
Misses 5886 5886 |
jenshnielsen
added a commit
that referenced
this pull request
Aug 20, 2019
use env markers for version specific deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://www.python.org/dev/peps/pep-0496/ for more info
This is the right solution for generating version independent whls that correctly handles dependencies