DB upgrade: version 5 - snapshot column ALWAYS present in runs table #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. now that snapshot column always exists in the runs table.
jenshnielsen
approved these changes
May 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #1562 +/- ##
==========================================
+ Coverage 71.54% 71.54% +<.01%
==========================================
Files 105 105
Lines 12137 12139 +2
==========================================
+ Hits 8683 8685 +2
Misses 3454 3454 |
1 task
giulioungaretti
pushed a commit
that referenced
this pull request
May 13, 2019
Merge: 57ad871 3a624d7 Author: Mikhail Astafev <[email protected]> Merge pull request #1562 from astafan8/db-upgrade-fix-snapshot-column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
snapshotcolumn (of type "TEXT") always present inrunstable. This way it becomes part of the stable schema, not a "metadata" column anymore.Relies on version 4 database generator from here QCoDeS/qcodes_generate_test_db#3.
Also couldn't resist fixing some of the style stuff.
ToDo:
qcodes_generate_test_dbqcodes_generate_test_dbto really the latest hash before merging this PR