Add support for complex values to Array validator #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
changed the title
jenshnielsen
commented
Feb 25, 2019
jenshnielsen
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1489 +/- ##
==========================================
+ Coverage 71.45% 71.54% +0.09%
==========================================
Files 105 105
Lines 12106 12133 +27
==========================================
+ Hits 8650 8681 +31
+ Misses 3456 3452 -4 |
jenshnielsen
force-pushed
the
feature/complex_array_validator
branch
2 times, most recently
from
e7e8abf to
896c310
Compare
jenshnielsen
changed the title
|
@QCoDeS/core I think this is ready for review |
astafan8
reviewed
Feb 26, 2019
astafan8
reviewed
Feb 26, 2019
jenshnielsen
force-pushed
the
feature/complex_array_validator
branch
from
688bf32 to
11b3974
Compare
astafan8
previously approved these changes
Feb 27, 2019
jenshnielsen
dismissed
astafan8’s stale review
I am going to block this from being merged until Williams changes to the type validation has been merged. Since there is a likelyhood of datalose for complex numbers without that.
jenshnielsen
force-pushed
the
feature/complex_array_validator
branch
2 times, most recently
from
35313ac to
dc61207
Compare
jenshnielsen
force-pushed
the
feature/complex_array_validator
branch
from
dc61207 to
45700b1
Compare
jenshnielsen
force-pushed
the
feature/complex_array_validator
branch
from
29cb681 to
eb2a1b3
Compare
Co-Authored-By: jenshnielsen <[email protected]>
Mem addresses can also be lowercase
Co-Authored-By: jenshnielsen <[email protected]>
jenshnielsen
force-pushed
the
feature/complex_array_validator
branch
from
eb2a1b3 to
9a158fe
Compare
|
@QCoDeS/core I think this is ready to land but needs a new review since I dismissed @astafan8 s original review. I don't think there are any important changes since then |
|
Then I'll let the other core devs do this review. |
|
@jenshnielsen sure, i didn't mean that :) just let's get some other pair of eyes to have a look at the change :) |
|
I think this looks good. Looking forward to see the first instrument use this. |
WilliamHPNielsen
approved these changes
May 7, 2019
giulioungaretti
pushed a commit
that referenced
this pull request
May 7, 2019
Merge: 52b5b1d 1b438bd Author: Jens Hedegaard Nielsen <[email protected]> Merge pull request #1489 from jenshnielsen/feature/complex_array_validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process discovered that the original typecheking for real values was actually not working so fixed that and added a test for it.