Add origin to parameter warnings #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make it easier to find and eliminate the last few cases of this outside qcodes and make it more clear that this will eventually be an error
|
This should probably have a test |
Codecov Report
@@ Coverage Diff @@
## master #1481 +/- ##
==========================================
+ Coverage 73.88% 73.92% +0.03%
==========================================
Files 92 92
Lines 10420 10420
==========================================
+ Hits 7699 7703 +4
+ Misses 2721 2717 -4 |
|
@QCoDeS/core This tiny change should be ready for review |
astafan8
approved these changes
Feb 20, 2019
giulioungaretti
pushed a commit
that referenced
this pull request
Feb 20, 2019
Merge: 46661dc 38ad18e Author: Jens Hedegaard Nielsen <[email protected]> Merge pull request #1481 from jenshnielsen/fix/better_parameter_warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We keep seeing these warnings in various instrument customization written by users.
This should make it easier to find and eliminate the last few cases of this outside qcodes and make it
more obvious to users what they need to fix.
In addition make it more clear that this will eventually be an error.