Ensure that partial run creation is completly rolled back #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, this is a great fix. I also agree with the need for a test. |
To ensure that runs are not partially created
jenshnielsen
force-pushed
the
db_metadata
branch
from
e4a58a6 to
47cf0ec
Compare
Codecov Report
@@ Coverage Diff @@
## master #1445 +/- ##
==========================================
+ Coverage 73.33% 73.34% +<.01%
==========================================
Files 91 91
Lines 10225 10226 +1
==========================================
+ Hits 7499 7500 +1
Misses 2726 2726 |
jenshnielsen
changed the title
This ensures that the runs are not only in memory but matches the db on disk
astafan8
approved these changes
Jan 15, 2019
giulioungaretti
pushed a commit
that referenced
this pull request
Jan 15, 2019
Merge: 3b5e79d 0c2183a Author: Jens Hedegaard Nielsen <[email protected]> Merge pull request #1445 from jenshnielsen/db_metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent bugs such as the first part of #1444 (invalid metadata dict) invalidating the database. This should really have a test if possible.