Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: fix __repr__ of Config #1403

Conversation

WilliamHPNielsen
Copy link
Contributor

@WilliamHPNielsen WilliamHPNielsen commented Nov 29, 2018

Fixes #1399

Changes proposed in this pull request:

  • Fix the typo in __repr__
  • Add another little test just so that we at least touch one hitherto untested method

@astafan8

@codecov
Copy link

codecov bot commented Nov 29, 2018

Codecov Report

Merging #1403 into master will increase coverage by 0.16%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1403      +/-   ##
==========================================
+ Coverage   72.22%   72.39%   +0.16%     
==========================================
  Files          83       83              
  Lines        9566     9566              
==========================================
+ Hits         6909     6925      +16     
+ Misses       2657     2641      -16

@WilliamHPNielsen WilliamHPNielsen merged commit 6899987 into microsoft:master Nov 29, 2018
giulioungaretti pushed a commit that referenced this pull request Nov 29, 2018
Merge: ffc6f06 a697e24
Author: William H.P. Nielsen <[email protected]>

    Merge pull request #1403 from WilliamHPNielsen/coverage/increase_config_coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants