More consistent table of content for notebooks #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the doc dept to the actual notebooks
Codecov Report
@@ Coverage Diff @@
## master #1362 +/- ##
==========================================
+ Coverage 73.15% 73.16% +0.01%
==========================================
Files 79 79
Lines 9155 9196 +41
==========================================
+ Hits 6697 6728 +31
- Misses 2458 2468 +10 |
|
@QCoDeS/core Could someone have a quick look at this? It's quite simple but makes the presentation of notebooks in the docs so much nicer |
| @@ -25,9 +24,9 @@ | |||
| "cell_type": "markdown", | |||
| "metadata": {}, | |||
| "source": [ | |||
| "# Experiment container and dasets\n", | |||
| "# Experiment container and datasets\n", | |||
There was a problem hiding this comment.
What is it about with the double # in the other notebooks? Sorry for not checking myself. I don't seem to find anything.
There was a problem hiding this comment.
ok now I get it sorry.... I was confused by the source view
Dominik-Vogel
approved these changes
Nov 2, 2018
|
Somehow my PR from yesterady fails here on 3.7, even though it passed in the original pr.... |
giulioungaretti
pushed a commit
that referenced
this pull request
Nov 2, 2018
Merge: 85d458f 958fa1e Author: Jens Hedegaard Nielsen <[email protected]> Merge pull request #1362 from jenshnielsen/notebook_toc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To render the notebooks nicely as part of our docs there should only be one 1 level heading at the top of the notebook. This changes a bunch of notebooks that had more.
In addition