Fix keithley 2600 formatting #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct formating to allow setting of low curr limits, add docstrings and validators to paramters
Codecov Report
@@ Coverage Diff @@
## master #1301 +/- ##
=======================================
Coverage 72.56% 72.56%
=======================================
Files 74 74
Lines 8456 8456
=======================================
Hits 6136 6136
Misses 2320 2320 |
astafan8
approved these changes
Oct 8, 2018
| @@ -156,13 +157,22 @@ def __init__(self, parent: Instrument, name: str, channel: str) -> None: | |||
| set_cmd='{}.source.rangev={}'.format(channel, | |||
| '{:.4f}'), | |||
| unit='V', | |||
| docstring='The range used when sourcing voltage' | |||
There was a problem hiding this comment.
. (dot and space) needed after this line?
| get_parser=float, | ||
| docstring='Number of power line cyclesm, used' |
There was a problem hiding this comment.
is the space needed after "used"?
| @@ -173,37 +183,53 @@ def __init__(self, parent: Instrument, name: str, channel: str) -> None: | |||
| set_cmd='{}.source.rangei={}'.format(channel, | |||
| '{:.4f}'), | |||
| unit='A', | |||
| docstring='The range used when sourcing current' | |||
| unit='A', | ||
| docstring='The range to perform current measurements' |
| 'in. This affects the range and the ' | ||
| 'precision of the measurement. ' | ||
| 'Note that if you both measure and source ' | ||
| 'current this will have no effect set ' |
There was a problem hiding this comment.
missing comma before "set"?
giulioungaretti
pushed a commit
that referenced
this pull request
Oct 8, 2018
Merge: 8979f3b 5d7f738 Author: William H.P. Nielsen <[email protected]> Merge pull request #1301 from jenshnielsen/fix_keithley_2600_formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix formatting of set commands with more than 4 significant digits after the comma. The instrument supports exponential notation so there is no need for specific formatting.
Also took the chance to add some validators, docstrings and typehints