Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate fixture dbs on azure #1300

Merged
merged 2 commits into from
Oct 5, 2018

Conversation

jenshnielsen
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Oct 5, 2018

Codecov Report

Merging #1300 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1300      +/-   ##
==========================================
+ Coverage   72.54%   72.55%   +0.01%     
==========================================
  Files          74       74              
  Lines        8456     8456              
==========================================
+ Hits         6134     6135       +1     
+ Misses       2322     2321       -1

@jenshnielsen
Copy link
Collaborator Author

@WilliamHPNielsen it looks like test_perform_actual_upgrade_1_to_2 is always skipped even on travis?

@WilliamHPNielsen
Copy link
Contributor

@jenshnielsen, that makes sense, since generate_version_1.py must be run to generate a .db-file for that test to consume. Seems like I forgot to add that before merging #1277

It would be good to add that here, also for Travis.

@jenshnielsen
Copy link
Collaborator Author

@WilliamHPNielsen done and the tests still pass :)

@jenshnielsen jenshnielsen merged commit 8979f3b into microsoft:master Oct 5, 2018
@jenshnielsen jenshnielsen deleted the add_db_tests_to_azure branch October 5, 2018 14:09
giulioungaretti pushed a commit that referenced this pull request Oct 5, 2018
Merge: 2f322c7 99e037d
Author: Jens Hedegaard Nielsen <[email protected]>

    Merge pull request #1300 from jenshnielsen/add_db_tests_to_azure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants