Fix decadac docstring #1282
Merged
Fix decadac docstring #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A decadac now contains all slots and channels and uses address and not port
This class is suboptimally implemented but works correctly because it's only meant to be used with a visa instrument as a mix in
astafan8
approved these changes
Sep 26, 2018
Codecov Report
@@ Coverage Diff @@
## master #1282 +/- ##
=======================================
Coverage 72.57% 72.57%
=======================================
Files 74 74
Lines 8473 8473
=======================================
Hits 6149 6149
Misses 2324 2324 |
|
mergeable? :) |
|
Yes, I would have liked to test it on a real instrument but I will do that in the next pr. This has zero functional changes |
giulioungaretti
pushed a commit
that referenced
this pull request
Oct 17, 2018
Merge: 0a72b2a 1144279 Author: Jens Hedegaard Nielsen <[email protected]> Merge pull request #1282 from jenshnielsen/fix_decadac_docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decadac docstrings were out of date mentioning port and not address and claimed that the driver does not support more than one slot.
This pr corrects that and pep8's the driver. I have also deleted the notebook for now. Once I get a chance test on an actual decadac I will write a new notebook. This has not been tested on an actual instrument but does hopefully not include any actual functional changes