StationConfigurator #1256
StationConfigurator #1256
Conversation
|
Was it decided that the stationconfigurator should not set up the part of the station concerning sample name and folder structure on the computer? |
|
Thank you @ThorvaldLarsen we are currently discussing were to set the sample name. I think there should not be anything to setup for the folder structure other than some entries in the qcodesrc. |
…s into station_configurator
| def load_file(self, filename: Optional[str] = None): | ||
|
|
||
| # 1. load config from file | ||
| if use_pyyaml: |
There was a problem hiding this comment.
Is there a reason to support usage of pyyaml? Seems like a good time to choose using ruamel (at least I think it is just better) instead of having two versions of dependencies spread in lab.
There was a problem hiding this comment.
Yes there is unfortunately. There has been an issue with writing back the meta data with ruamel.. I still haven't found out why this happens but I am happy they have pyaml.
…s into station_configurator
Includes YAML configuration help info
|
@QCoDeS/core I've added some minimal documentation about Station configuration and Station itself. Please feel free to review that as well. |
…s into station_configurator
Mikhail Astafev. When building docs locally, the “dataset context manager” example notebook takes too much time to execute to_xarray in the scatter plot example. is it because xarray is trying to make a grid out of 5000 ungridded points? It's weird because the conversion is executed on a 10-rows dataframe - a very small one. But the resulting xarray has 5000 in its dimensions, as if it was made out of the original huge dataframe. I tried with "copy" - still the same problem. to_dict, to_json, etc - work on a copy, no problem, but to_xarray goes nuts and processes all the 5000 rows from the parent dataframe which it should not know about since I made a “copy”.
of Station example notebook
now for snapshot notebook
not the old 'station_configurator'
... in Dataset context manager example notebook. Based on this pandas-dev/pandas#3686.
|
Moving this to a new clean PR before final merge. |
Migrating the
StationConfiguratorfrom qdev-wrappers.qdev-dk/qdev-wrappers#68
Merging the
StationConfiguratorwith theStation. TheStationConfiguratorhas been a separate object in qdev_wrappers because theStationlives in qcodes core, but it conceptionally belongs into theStation.The Station is meant to be a representation of the physical setup. And this description is given by the station config yaml file.
So far the station has methods for snapshotting:
snapshot_baseadd_componentand default measurements:
set_measurementmeasureand in this pr methods for serialization from a yaml are added:
load_config_fileload_instrumentI suggest that we deprecate the default measurement funcitonality in another PR, because as far as I know it is not used and it is only used by the legacy loop. Removing these function would further decouple dependencies.
I also suggest that we accommodate the control over the sample name in the
Stationobject. (this would also satisfy @ThorvaldLarsen s request.)Previous bootstrapping looked like this:
With this an experiment is bootstrapped by simply
To go in small steps this PR addresses the minimal integration of the station configurator in the station. In late PRs documentation and possible refactorings of the internal structure might follow. Lets think about what we are committing to with this PR.