Defaults for Smart color scale #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1255 +/- ##
=========================================
- Coverage 70.51% 70.5% -0.02%
=========================================
Files 74 74
Lines 8092 8095 +3
=========================================
+ Hits 5706 5707 +1
- Misses 2386 2388 +2 |
jenshnielsen
reviewed
Sep 3, 2018
qcodes/dataset/plotting.py
Outdated
| @@ -29,7 +30,7 @@ def plot_by_id(run_id: int, | |||
| Sequence[ | |||
| matplotlib.colorbar.Colorbar]]]=None, | |||
| rescale_axes: bool=True, | |||
| smart_colorscale: bool=False) -> AxesTupleList: | |||
| smart_colorscale: Union[bool,None]=None) -> AxesTupleList: | |||
There was a problem hiding this comment.
This should be Optional[bool] i think. Which is equivalent but less ugly
jenshnielsen
reviewed
Sep 3, 2018
qcodes/dataset/plotting.py
Outdated
| @@ -68,6 +69,9 @@ def plot_by_id(run_id: int, | |||
| colorbar axes may be None if no colorbar is created (e.g. for | |||
| 1D plots) | |||
| """ | |||
| # defaults | |||
| smart_colorscale = smart_colorscale or config.gui.smart_colorscale | |||
There was a problem hiding this comment.
Is this logic correct?
None or True => True
None or False => False
True or False => True
True or True => True
False or False => True
Seems correct
but
False or True => True
seems wrong to me?
I.e if you pass False to the function but it's enabled in the config it will be enabled anyway?
There was a problem hiding this comment.
That is indeed a very good point.
jenshnielsen
approved these changes
Sep 3, 2018
giulioungaretti
pushed a commit
that referenced
this pull request
Sep 4, 2018
Merge: 4cfcf7a 7a3849c Author: Dominik Vogel <[email protected]> Merge pull request #1255 from Dominik-Vogel/smart_color_scale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a commit that got lost in the pipeline to #1253