Bug: snapshot fails when instantiating InstrumentBase #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astafan8
requested review from
jenshnielsen,
sohailc,
WilliamHPNielsen and
Dominik-Vogel
Codecov Report
@@ Coverage Diff @@
## master #1209 +/- ##
==========================================
- Coverage 80.16% 80.16% -0.01%
==========================================
Files 49 49
Lines 6762 6761 -1
==========================================
- Hits 5421 5420 -1
Misses 1341 1341 |
|
It's not so clear to me what is gained by instantiating |
|
yeah, it is more for subclassing |
giulioungaretti
pushed a commit
that referenced
this pull request
Jul 30, 2018
Merge: 897ffbc 5ea8e0d Author: Mikhail Astafev <[email protected]> Merge pull request #1209 from astafan8/bugfix/meta-attr-name-instrument-base
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem occurs when one wants to subclass from
InstrumentBase(or instantiate it). The reason to do so is to create a "virtual" instrument, and to avoid the overhead ofInstrumentclass related to the register of instances.The problem is that the snapshot functionality of
InstrumentBaseraises an exception saying "the object does not have attribute_meta_attrs". This is becausesnapshot_baseuses it, but for some reason_meta_attrsis only defined in theInstrumentclass. This is not correct, hence this PR.Changes:
_meta_attrsinInstrumentBaseinstead ofInstrumentInstrumentBaseInstrumenttest to ensure snapshotting still works for it