driver / RUDAT 13G 90

[sohailc]

Added a driver for the microcircuits RUDAT 13G 90 attenutator

[codecov]

Codecov Report

Merging #1073 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1073   +/-   ##
=======================================
  Coverage   78.66%   78.66%           
=======================================
  Files          46       46           
  Lines        6478     6478           
=======================================
  Hits         5096     5096           
  Misses       1382     1382

[Dominik-Vogel]

Great that you could implement the pywinusb library, like in PR #813. Yes, you are right, this version here is more condensed. The reason the original version in #813 is less condensed is, that it is more general in the sense that it provides a usb mixin class that should in principle be possible to use in all similar devices.
Your reimplementation also will run into problems once you have multiple devices of the same type.
I also noted that the IDN format is not conforming with the other devices.

[Dominik-Vogel]

Looking at it again I think you should build on the old PR. You can simply push to that branch.

[sohailc]

Actually, @Dominik-Vogel , I think I should keep the new PR. Your PR (#813) adds a driver for the rcdat_6000_60, which I do not have. I would either have to remove your driver or I'd have to push untested code, neither of which is desirable. I think we should merge this PR (once it is approved) and then in your branch you can use my mixin class.

[sohailc]

Using a Mixin class did not work well with mypy. A similar situation is described here:
python/mypy#4001

I think the only solution is to make a subclass USBHIDInstrument and inherit from that.

[Dominik-Vogel]

Dear @sohailc, I would prefer making a mixin and make an exception for mypy until the issue gets resolved. The reason for this is, that mypy is checking, a commodity feature, and the mixin is required to not repeat the same code: For minicircuits there exist quite a few devices that are ethernet and usb connectable. If you want to make a consistent driver you can implement all the same commands and then only add a mixin for the usb case.

[sohailc]

Ok, I am using a Mixin, have another look, @Dominik-Vogel

[Dominik-Vogel]

I would suggest one last change:
the vendor_id and product_id should be set to some invalid value in the mixin and then get their current values in the RUDAT_13G_90_USB