Skip to content

Commit

Permalink
Visa improvements to snapshot
Browse files Browse the repository at this point in the history
Get value of terminator from visa_handle.read_termination
Its not clear if this should be read or write and really we should
log both so extend snapshot with explicit read and write terminators
  • Loading branch information
jenshnielsen committed Jun 2, 2022
1 parent 3d69771 commit 454e53f
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions qcodes/instrument/visa.py
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,10 @@ def snapshot_base(self, update: Optional[bool] = True,
snap = super().snapshot_base(update=update,
params_to_skip_update=params_to_skip_update)

snap['address'] = self._address
snap['terminator'] = self._terminator
snap['timeout'] = self.timeout.get()
snap["address"] = self._address
snap["terminator"] = self.visa_handle.read_termination
snap["read_terminator"] = self.visa_handle.read_termination
snap["write_terminator"] = self.visa_handle.write_termination
snap["timeout"] = self.timeout.get()

return snap

0 comments on commit 454e53f

Please sign in to comment.