[Peek] Terminate Preview Handlers Processes#40116
Merged
Conversation
davidegiacometti
force-pushed
the
users/davidegiacometti/peek-terminate-previewhandler
branch
from
1d5879c to
419b463
Compare
crutkas
added
Needs-Review
lei9444
reviewed
Jul 11, 2025
| } | ||
| CloseHandle(m_hProcess); | ||
|
|
||
| CloseHandle(hProcess); |
Contributor
There was a problem hiding this comment.
m_hProcess should be closed too
| { | ||
| foreach (var factory in HandlerFactories.Values) | ||
| { | ||
| Marshal.FinalReleaseComObject(factory); |
Contributor
There was a problem hiding this comment.
Consider adding try-catch here to guard against exceptions.
Collaborator
Author
|
Hi @lei9444, thanks for the review! I have addressed the feedback. |
lei9444
approved these changes
Jul 14, 2025
davidegiacometti
deleted the
users/davidegiacometti/peek-terminate-previewhandler
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This is an attempt to release Preview Handlers instantiated by Peek and close the related processe.
I noticed that sometimes the process gets leaked also when Preview Handler is used in Explorer 🤔
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Tested manually: