Fix RunAsAdmin For CmdPal when PowerToys is running as Admin#39448
Merged
zadjii-msft merged 1 commit intomainfrom May 15, 2025
Merged
Fix RunAsAdmin For CmdPal when PowerToys is running as Admin#39448zadjii-msft merged 1 commit intomainfrom
zadjii-msft merged 1 commit intomainfrom
Conversation
yeelam-gordon
requested review from
Copilot,
vanzue and
zadjii-msft
and removed request for
Copilot and
vanzue
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue where CmdPal was not being launched as admin when PowerToys runs as admin. The change adjusts the launch method to leverage explorer.exe, which runs with standard user privileges, to start CmdPal.
Comments suppressed due to low confidence (1)
src/modules/cmdpal/CmdPalModuleInterface/dllmain.cpp:220
- [nitpick] Consider verifying that explorer.exe correctly parses and forwards the command line arguments, and use quotes if needed for paths or arguments with spaces.
std::wstring launchPath = L"explorer.exe x-cmdpal://background";
zadjii-msft
approved these changes
May 15, 2025
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yeelam-gordon
added a commit
that referenced
this pull request
May 19, 2025
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Since we change the launch method by this PR #39269 , we will start cmdpal as admin too if powertoys run as admin. The fix is leveraging explorer (which will not run as admin) to start the cmdpal Moreover, without this fix, some of extension cannot be "loaded" when cmdpal run as admin, e.g. winget will be missing, and my own new extension developed by myself will not be loaded successful as well.
|
how can I apply this fix to mine? |
yeelam-gordon
added
the
Product-Command Palette
sadirano
pushed a commit
to sadirano/PowerToys
that referenced
this pull request
Jun 10, 2025
…ft#39448) <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Since we change the launch method by this PR microsoft#39269 , we will start cmdpal as admin too if powertoys run as admin. The fix is leveraging explorer (which will not run as admin) to start the cmdpal Moreover, without this fix, some of extension cannot be "loaded" when cmdpal run as admin, e.g. winget will be missing, and my own new extension developed by myself will not be loaded successful as well.
yeelam-gordon
added a commit
that referenced
this pull request
Jun 20, 2025
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> Since we change the launch method by this PR #39269 , we will start cmdpal as admin too if powertoys run as admin. The fix is leveraging explorer (which will not run as admin) to start the cmdpal Moreover, without this fix, some of extension cannot be "loaded" when cmdpal run as admin, e.g. winget will be missing, and my own new extension developed by myself will not be loaded successful as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Since we change the launch method by this PR #39269 , we will start cmdpal as admin too if powertoys run as admin.
The fix is leveraging explorer (which will not run as admin) to start the cmdpal
Moreover, without this fix, some of extension cannot be "loaded" when cmdpal run as admin, e.g. winget will be missing, and my own new extension developed by myself will not be loaded successful as well.