CmdPal: fix a perf regression loading pages#39415
Merged
zadjii-msft merged 1 commit intomainfrom May 16, 2025
Merged
Conversation
This was especially noticable with the icons extension. Turns out in #39051, when I was experimenting with getting AoT clean, i accidentally called this twice. Then we actually commited that straight up. This PR reverts that. It also moves a similar case where we were initializing all the tags on the UI thread. That's wrong too - we need to fetch properties off the UI thread, then update the list on the UI thread. Closes nothing, I didn't file this yet.
zadjii-msft
added
the
Product-Command Palette
zadjii-msft
added
the
Needs-Review
DHowett
approved these changes
May 15, 2025
| async () => | ||
| () => | ||
| { | ||
| // bool f = await viewModel.InitializeCommand.ExecutionTask.; |
yeelam-gordon
removed
the
Needs-Review
sadirano
pushed a commit
to sadirano/PowerToys
that referenced
this pull request
Jun 10, 2025
This was especially noticable with the icons extension. Turns out in microsoft#39051, when I was experimenting with getting AoT clean, i accidentally called this twice. Then we actually commited that straight up. This PR reverts that. It also moves a similar case where we were initializing all the tags on the UI thread. That's wrong too - we need to fetch properties off the UI thread, then update the list on the UI thread. Closes nothing, I didn't file this yet.
yeelam-gordon
pushed a commit
that referenced
this pull request
Jun 20, 2025
This was especially noticable with the icons extension. Turns out in #39051, when I was experimenting with getting AoT clean, i accidentally called this twice. Then we actually commited that straight up. This PR reverts that. It also moves a similar case where we were initializing all the tags on the UI thread. That's wrong too - we need to fetch properties off the UI thread, then update the list on the UI thread. Closes nothing, I didn't file this yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was especially noticeable with the icons extension.
Turns out in #39051, when I was experimenting with getting AoT clean, I accidentally called this twice. Then we actually committed that straight up.
This PR reverts that. It also moves a similar case where we were initializing all the tags on the UI thread. That's wrong too - we need to fetch properties off the UI thread, then update the list on the UI thread.
Closes nothing, I didn't file this yet.