Merge main branch#39409
Conversation
empowering users to maximize to their heart desire
related issue: #38713
## Summary of the Pull Request 1. Add new fallback command for websearch https://github.com/user-attachments/assets/39362d66-db59-42d4-b07c-7bfd60b2e420 ## PR Checklist - [x] **Closes:** #38497 --------- Co-authored-by: Yu Leng (from Dev Box) <yuleng@microsoft.com>
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Added a settings to enable/disable the system tray icon (enabled by default). Adopter the term "system tray icon" for consistency with Windows 11 settings. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] **Closes:** #38407
* Add Zhiwei as part of PowerToys! * Fix the expect.txt for Zhiwei * Fix the case problem on expect.txt zhiwei => Zhiwei
* Add QuickNotes plugin to third-party Run plugins documentation * chore: add ruslanlap to spelling allow-list * chore: add ruslanlap to spelling allow-list * chore: add ruslanlap to spelling allow-list * Add ruslanlap to allowed names and remove from expected words list
For the winget DSC, Setting developer mode, installing Visual Studio 2022 & fetching and installing VS components all require elevation. Added securityContext: elevated for these resources. These configurations can now be invoked from user context, and will prompt for a single UAC to run resources that require elevation in a separate process.
* Change log extension From .txt to .log * Also add workspace logs --------- Co-authored-by: Jaime Bernardo <jaime@janeasystems.com>
* Fix ctr,alt,shift getting stuck * more changes * Update src/modules/keyboardmanager/common/Helpers.h Co-authored-by: Hao Liu <liuhaobupt@163.com> --------- Co-authored-by: Hao Liu <liuhaobupt@163.com>
* Fix Color Picker resource leak (#38122) Added a using statement to properly dispose of the Graphics object created from the Bitmap. This fixes resource leak. * Fix CI complain * Update MouseInfoProvider.cs fix whitespace --------- Co-authored-by: Kai Tao <69313318+vanzue@users.noreply.github.com>
* starting to get some of the baseline * Update NOTICE.md * Upgrading streamjson gets the others on same version of newtonsoft.json * Update PowerToys.Settings.csproj * Update NOTICE.md
* upgrading to adjust fix vulnerablitlity * Update NOTICE.md * Update NuGet packages in NOTICE.md
…38760) * [PowerToysRun][Docs] Add Weather and Pomodoro to Third-Party plugins * [Spell-check] Add ruslanlap to allowed names and update expect.txt * Update expect.txt * Update names.txt * Update names.txt * Update names.txt * Update names.txt
* [cmdpal] Fix alias update * Fix the command palette extension alias update issue * clean code --------- Co-authored-by: vanzue <vanzue@outlook.com>
This update aligns with Microsoft's security guidelines by pinning all GitHub Action tags and Docker tags to their full-length commits. This practice ensures immutability and reduces the risk of supply chain attacks. Note that 1st and 2nd party actions do not require hash pinning.
**WARNING:** This PR will probably blow up all in-flight PRs at some point in the early days of CmdPal, two of us created seperate `Exts` and `exts` dirs. Depending on what the casing was on the branch that you checked one of those out from, it'd get stuck like that on your PC forever. Windows didn't care, so we never noticed. But GitHub does care, and now browsing the source on GitHub is basically impossible. Closes #38081
Upgrading Boost
* upgrade toolkit to latest * supressing warnings * Update expect.txt making generic * Update suppression comments for AOT compatibility * Fix case for 'MVVMTK' in spell-check file * Update NOTICE.md
…0703) (#38723) * [PowerRename][Feature] Add new date/time formatting patterns to GetDatedFileName * [PowerRename][UI] Add date/time shortcut patterns to cheat sheet * [PowerRename][Tests] Add tests for new date/time formatting patterns * [PowerRename] [Refactor] Simplify AM/PM string handling in time patterns
… Extension" command. (#38864) Co-authored-by: Yu Leng (from Dev Box) <yuleng@microsoft.com>
* fix on-screen keyboard activation * cleanup
Adds the ability to make the global CmdPal hotkey a low-level hook. This is needed for `win+space`, `win+r`, et al. I've only added this to the root hotkey. Other hotkeys will still use the normal `RegisterHotkey` ones. We can re-evaluate this for 0.2+. Originally: zadjii-msft#349 Solves: #38297 --------- Co-authored-by: Mike Griese <migrie@microsoft.com>
Adds a parameter to `Toolkit.ThumbnailHelper.GetThumbnail` to retrieve the largest possible icon from the file. For most use cases, the normal icon size will be good for list items and page icons. But for details, you'll want to use the JUMBO icons, and to retrieve them, we need to get the icon from a different API. As a drive-by, I also have us fetching the highest-res app icon for UWP's rather than the lowest-res icon. Solves #38238 Screenshots: | before | after | | ------ | ----- | |  |  | |  |  |
* changes * fix resx
Apps that want to show MSAL dialogs on the Command Palette would explode if they passed CmdPal's HWND to WithParentActivityOrWindow. It's not entirely clear why, but MSAL would explode if the parent HWND is hidden. When the MSAL dialog opened, we'd hide ourselves, and badda bing, badda boom, the extension would crash. MSAL dialogs will set us to WS_DISABLED right before the dialog is opened. Easy solution. Don't hide ourselves, if we're disabled. Helps some friends not depend on the existence of Teams :P
closes #38712 closes #38315 related to #38379 (and might sufficiently close that too) This immediately selects the search text when a page is loaded. 
* Turning description into a hyperlink * Update expect.txt * Update CmdPalPage.xaml.cs * update xaml format. Signed-off-by: Shawn Yuan <shuai.yuan.zju@gmail.com> * update. Signed-off-by: Shawn Yuan <shuaiyuan@microsoft.com> * Added logger Signed-off-by: Shawn Yuan <shuai.yuan.zju@gmail.com> * update Signed-off-by: Shawn Yuan <shuai.yuan.zju@gmail.com> --------- Signed-off-by: Shawn Yuan <shuai.yuan.zju@gmail.com> Signed-off-by: Shawn Yuan <shuaiyuan@microsoft.com> Co-authored-by: Shawn Yuan <shuai.yuan.zju@gmail.com> Co-authored-by: Shawn Yuan <shuaiyuan@microsoft.com>
Extensions can change the properties on their Details, and they should be observable, but they weren't. This is because the ShellPage is ultimately responsible for exposing the details, but it doesn't own the details. The selected ListItemViewModel from the ListPage does. This PR just adds a event handler on ListViewModel. We'll attach/detach that handler to ListItemViewModels as the selection changes. In the body of that handler, we'll let the ShellPage know when the details object changes (by sending ShowDetails/HideDetails messages). Closes #39216
This bumps the version of the toolkit consumed by the template to 0.2.0 ~Ironically, I have not yet published 0.2. I'm spinning that CI build currently. But I'll have that uploaded tomorrow morning at the latest~ EDIT: package is uploaded now
* remove new label from cmdpal * fix xaml styling
disable by default Co-authored-by: Yu Leng (from Dev Box) <yuleng@microsoft.com>
…sue (#39324) init Co-authored-by: Yu Leng (from Dev Box) <yuleng@microsoft.com>
change areaPath for fuzzing test config
* Add log to trace error for apps. * Add bookmark log * registry exception log * fix * Added logger for cmdpal extensions. Signed-off-by: Shawn Yuan <shuaiyuan@microsoft.com> * remove noise * Update Signed-off-by: Shawn Yuan <shuaiyuan@microsoft.com> * change log level * change level * Fix comments * Fixed comments. Signed-off-by: Shawn Yuan <shuaiyuan@microsoft.com> * Resolve comments Signed-off-by: Shawn Yuan <shuaiyuan@microsoft.com> --------- Signed-off-by: Shawn Yuan <shuaiyuan@microsoft.com> Co-authored-by: Shawn Yuan <shuaiyuan@microsoft.com>
Data collection is hard. Our internal package, which was last bumped around August 2024, mistakenly changed a load bearing string from `ETW_GROUP` to `MSPG_GROUP`. The former sets the ETW group id. The later does nothing. This PR represents bumping our dependency to the version with the fix. Considering that none of our data for CmdPal worked anyways, I took the opportunity to rename a bunch of our events that had totally generic names. Closes #38704 re: #38032 regressed around: #34078
Updates .NET 9 Runtime / Library packages to the latest 9.0.5 servicing release for security fixes. This PR also updates the version of System.Text.Json to 9.0.5 in the CmdPal extension template.
…39398) * add Testably.Abstractions.FileSystem.Interface.dll * fix spell error
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (31)These words are not needed and should be removedDEFT DPIs iextn pswd SHELLEXTENSION SHELLNEWVALUE SHGFIICON SHGFILARGEICONTo accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the git@github.com:microsoft/PowerToys.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/15014931873/attempts/1'
Forbidden patterns 🙅 (2)In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves. These forbidden patterns matched content: Should be
|
| ❌ Errors | Count |
|---|---|
| ❌ forbidden-pattern | 2 |
| ❌ ignored-expect-variant | 2 |
| 1 |
See ❌ Event descriptions for more information.
If the flagged items are 🤯 false positives
If items relate to a ...
-
binary file (or some other file you wouldn't want to check at all).
Please add a file path to the
excludes.txtfile matching the containing file.File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.
^refers to the file's path from the root of the repository, so^README\.md$would exclude README.md (on whichever branch you're using). -
well-formed pattern.
If you can write a pattern that would match it,
try adding it to thepatterns.txtfile.Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.
Note that patterns can't match multiline strings.
There was a problem hiding this comment.
Pull Request Overview
This PR merges the main branch into the feature/UITestAutomation branch and updates various dependency versions and pipeline scripts. Key changes include updating package versions in Directory.Packages.props, revising pipeline scripts to improve versioning and security contexts, and updating configuration files and templates for enhanced CI/CD behavior.
Reviewed Changes
Copilot reviewed 645 out of 645 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Directory.Packages.props | Updated dependency versions to newer release numbers |
| COMMUNITY.md | Added a new team member entry |
| .pipelines/verifyCommonProps.ps1 | Added a new script for verifying common properties in C# projects |
| .pipelines/v2/templates/steps-update-winappsdk-and-restore-nuget.yml | Added rootPath argument to the WinAppSDK restore step |
| .pipelines/v2/templates/job-build-project.yml | Introduced audit step for Common.props import in C# projects |
| .pipelines/v2/release.yml | Changed release steps to use PowerShell and updated telemetry file moves |
| .pipelines/v2/ci-using-the-latest-winappsdk.yml | Updated default WinAppSDK version from 1.6 to 1.7 |
| .pipelines/tsa.json | Modified areaPath for notifications |
| .pipelines/packages.config | Upgraded the Telemetry package version |
| .pipelines/UpdateVersions.ps1 | Updated parameters and file updates for version management |
| .pipelines/ESRPSigning_core.json | Added new DLL signing entries |
| .github/workflows/spelling2.yml | Updated check-spelling action version reference |
| .github/workflows/dependency-review.yml | Added dependency review workflow |
| .github/actions/spell-check/* | Revised spell-check configuration and allowed names/code lists |
| .github/ISSUE_TEMPLATE/bug_report.yml | Modified input fields and added an additional information field |
| .config/configuration*.winget | Updated winget configuration with securityContext for elevation |
Comments suppressed due to low confidence (1)
.pipelines/UpdateVersions.ps1:160
- The variable '$WinAppSDKVersion' is used in this line, but the parameter is defined as '$winAppSdkVersionNumber'. Please ensure the variable naming is consistent.
$newVersionString = 'PackageReference Include="Microsoft.WindowsAppSDK" Version="'+ $WinAppSDKVersion + '"'
Merge main branch to feature/UITestAutomation