Skip to content

[cmdpal][aot] Remove some unused file in CmdPal.Common and mark it as AOT compatible. #39110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moooyo merged 8 commits into from
Apr 27, 2025
Merged

[cmdpal][aot] Remove some unused file in CmdPal.Common and mark it as AOT compatible. #39110

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b62f3da
init
Apr 24, 2025
a4fe6ba
Merge remote-tracking branch 'origin/yuleng/aot/cmdpalCommon' into yu…
Apr 25, 2025
325df79
init
Apr 25, 2025
7cc17ca
Remove unused com interface
Apr 25, 2025
2095ab1
Merge branch 'main' into yuleng/cmdpal/aot/b4
Apr 27, 2025
f25f5c8
Remove unused file
Apr 27, 2025
d9743f7
Remove unused file
Apr 27, 2025
72071cb
Remove unused file
Apr 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions src/modules/cmdpal/Microsoft.CmdPal.Common/Contracts/IFileService.cs
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions src/modules/cmdpal/Microsoft.CmdPal.Common/Contracts/ILocalSettingsService.cs
View file
Open in desktop

This file was deleted.

40 changes: 0 additions & 40 deletions src/modules/cmdpal/Microsoft.CmdPal.Common/Extensions/ApplicationExtensions.cs
View file
Open in desktop

This file was deleted.

40 changes: 0 additions & 40 deletions src/modules/cmdpal/Microsoft.CmdPal.Common/Extensions/IHostExtensions.cs
View file
Open in desktop

This file was deleted.

36 changes: 0 additions & 36 deletions src/modules/cmdpal/Microsoft.CmdPal.Common/Helpers/Json.cs
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/modules/cmdpal/Microsoft.CmdPal.Common/Helpers/NativeEventWaiter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

namespace Microsoft.CmdPal.Common.Helpers;

public static class NativeEventWaiter
public static partial class NativeEventWaiter
{
public static void WaitForEventLoop(string eventName, Action callback)
{
Expand Down
2 changes: 1 addition & 1 deletion src/modules/cmdpal/Microsoft.CmdPal.Common/Helpers/RuntimeHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

namespace Microsoft.CmdPal.Common.Helpers;

public static class RuntimeHelper
public static partial class RuntimeHelper
{
public static bool IsMSIX
{
Expand Down
16 changes: 16 additions & 0 deletions ...ules/cmdpal/Microsoft.CmdPal.Common/JsonSerilizationContext/CommonSerializationContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// Copyright (c) Microsoft Corporation

Check failure

Code scanning / check-spelling

Check File Path

[Serilization](#security-tab) is not a recognized word. \(check-file-path\)
// The Microsoft Corporation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using System.Text.Json.Serialization;

namespace Microsoft.CmdPal.Common.JsonSerilizerContext;

Check failure

Code scanning / check-spelling

Unrecognized Spelling

[Serilizer](#security-tab) is not a recognized word. \(unrecognized-spelling\)

[JsonSerializable(typeof(float))]
[JsonSerializable(typeof(int))]
[JsonSerializable(typeof(string))]
[JsonSerializable(typeof(bool))]
[JsonSourceGenerationOptions(UseStringEnumConverter = true, WriteIndented = true, IncludeFields = true, PropertyNameCaseInsensitive = true, AllowTrailingCommas = true)]
internal sealed partial class CommonSerializationContext : JsonSerializerContext
{
}
2 changes: 1 addition & 1 deletion src/modules/cmdpal/Microsoft.CmdPal.Common/Messages/HideWindowMessage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@

namespace Microsoft.CmdPal.Common.Messages;

public record HideWindowMessage()
public partial record HideWindowMessage()
{
}
1 change: 1 addition & 0 deletions src/modules/cmdpal/Microsoft.CmdPal.Common/Microsoft.CmdPal.Common.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<Import Project="..\..\..\Common.Dotnet.CsWinRT.props" />
<Import Project="..\..\..\Common.Dotnet.AotCompatibility.props" />
<PropertyGroup>
<RootNamespace>Microsoft.CmdPal.Common</RootNamespace>
<Nullable>enable</Nullable>
Expand Down
2 changes: 1 addition & 1 deletion src/modules/cmdpal/Microsoft.CmdPal.Common/Models/LocalSettingsOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

namespace Microsoft.CmdPal.Common.Models;

public class LocalSettingsOptions
public partial class LocalSettingsOptions
{
public string? ApplicationDataFolder
{
Expand Down
9 changes: 0 additions & 9 deletions src/modules/cmdpal/Microsoft.CmdPal.Common/NativeMethods.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,7 @@
EnableWindow
CoCreateInstance
FileOpenDialog
FileSaveDialog
IFileOpenDialog
IFileSaveDialog
SHCreateItemFromParsingName
GetCurrentPackageFullName
SetWindowLong
GetWindowLong
WINDOW_EX_STYLE
SHLoadIndirectString
StrFormatByteSizeEx
SFBS_FLAGS
MAX_PATH
GetDpiForWindow
Expand Down
48 changes: 0 additions & 48 deletions src/modules/cmdpal/Microsoft.CmdPal.Common/Services/FileService.cs
View file
Open in desktop

This file was deleted.

120 changes: 0 additions & 120 deletions src/modules/cmdpal/Microsoft.CmdPal.Common/Services/LocalSettingsService.cs
View file
Open in desktop

This file was deleted.