Skip to content

Wait to update SearchText until we've actually updated SearchText #39093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zadjii-msft merged 1 commit into from
Apr 27, 2025
Merged

Wait to update SearchText until we've actually updated SearchText #39093

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/PageViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ protected virtual void FetchProperty(string propertyName)
return; // throw?
}

var updateProperty = true;
switch (propertyName)
{
case nameof(Name):
Expand All @@ -198,9 +199,21 @@ protected virtual void FetchProperty(string propertyName)
case nameof(Icon):
this.Icon = new(model.Icon);
break;
default:
updateProperty = false;
break;
}

UpdateProperty(propertyName);
// GH #38829: If we always UpdateProperty here, then there's a possible
// race condition, where we raise the PropertyChanged(SearchText)
// before the subclass actually retrieves the new SearchText from the
// model. In that race situation, if the UI thread handles the
// PropertyChanged before ListViewModel fetches the SearchText, it'll
// think that the old search text is the _new_ value.
if (updateProperty)
{
UpdateProperty(propertyName);
}
}

public new void ShowException(Exception ex, string? extensionHint = null)
Expand Down
Loading