Skip to content

Fully initialize context menus when they change #38998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zadjii-msft merged 5 commits into from
Apr 23, 2025
Merged

Fully initialize context menus when they change #38998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a72c6a0
Definitely need this
zadjii-msft Apr 21, 2025
74bcc1b
May not need this
zadjii-msft Apr 21, 2025
e47bd1c
Revert "May not need this"
zadjii-msft Apr 21, 2025
e0e870a
Revert "Revert "May not need this""
zadjii-msft Apr 21, 2025
519cfa9
good catch
zadjii-msft Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/CommandBarViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ public ICommandBarContext? SelectedItem

field = value;
SetSelectedItem(value);

OnPropertyChanged(nameof(SelectedItem));
}
}

Expand Down Expand Up @@ -115,6 +117,10 @@ private void UpdateContextItems()
{
ShouldShowContextMenu = false;
}

OnPropertyChanged(nameof(HasSecondaryCommand));
OnPropertyChanged(nameof(SecondaryCommand));
OnPropertyChanged(nameof(ShouldShowContextMenu));
Copy link
Contributor

@vanzue vanzue Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need to call this "ShouldShowContextMenu" twice?

}

// InvokeItemCommand is what this will be in Xaml due to source generator
Expand Down
2 changes: 1 addition & 1 deletion src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/ContentPageViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ protected override void FetchProperty(string propertyName)

Commands.ForEach(contextItem =>
{
contextItem.InitializeProperties();
contextItem.SlowInitializeProperties();
});
}
else
Expand Down
4 changes: 3 additions & 1 deletion src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/ListViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ protected override void FetchProperty(string propertyName)
break;
case nameof(EmptyContent):
EmptyContent = new(new(model.EmptyContent), PageContext);
EmptyContent.InitializeProperties();
EmptyContent.SlowInitializeProperties();
break;
case nameof(IsLoading):
UpdateEmptyContent();
Expand All @@ -454,6 +454,8 @@ private void UpdateEmptyContent()
return;
}

UpdateProperty(nameof(EmptyContent));

DoOnUiThread(
() =>
{
Expand Down
Loading