Skip to content

Update the settings form when ext settings are saved #38851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zadjii-msft merged 3 commits into from
Apr 16, 2025
Merged

Update the settings form when ext settings are saved #38851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0585bba
Update the settings form when ext settings are saved
zadjii-msft Apr 14, 2025
0753cd8
Merge remote-tracking branch 'origin/main' into dev/migrie/b/38191-up…
zadjii-msft Apr 15, 2025
7d9e529
straggler?
zadjii-msft Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsServices/Properties/Resources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions src/modules/cmdpal/extensionsdk/Microsoft.CommandPalette.Extensions.Toolkit/Settings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@ public SettingsContentPage(Settings settings)
_settings = settings;
Name = "Settings";
Icon = new IconInfo("\uE713"); // Settings icon

// When our settings change, make sure to let CmdPal know to
// retrieve the new forms
_settings.SettingsChanged += (s, e) => RaiseItemsChanged();
}
}

Expand Down
6 changes: 6 additions & 0 deletions src/modules/cmdpal/extensionsdk/Microsoft.CommandPalette.Extensions.Toolkit/SettingsForm.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ public override ICommandResult SubmitForm(string inputs, string data)
return CommandResult.KeepOpen();
}

// Re-render the current value of the settings to a card. The
// SettingsContentPage will raise an ItemsChanged in its own
// SettingsChange handler, so we need to be prepared to return the
// current settings value.
TemplateJson = _settings.ToFormJson();

_settings.Update(inputs);
_settings.RaiseSettingsChanged();

Expand Down
Loading