-
Notifications
You must be signed in to change notification settings - Fork 8.3k
[CmdPal] MinWidth/Height and DPI-aware launch dimensions #38637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
319dfec
MinWidth/Height and DPI-aware launch dimensions
niels9001 c4da159
Making MainWindow DPI aware too
niels9001 602666d
Moving toastwindow to WinUIEx too
niels9001 141c678
Merge branch 'main' into user/niels9001/cmdpal-windowing
niels9001 429f636
Update MainWindow.xaml.cs
niels9001 1ab500d
Reverting back to the working logic
niels9001 8fc2d05
Localizing settings window title
niels9001 190a544
Xaml formatting
niels9001 de19be5
Update SettingsWindow.xaml.cs
niels9001 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,17 @@ | ||
| <Window | ||
| <winuiex:WindowEx | ||
| x:Class="Microsoft.CmdPal.UI.MainWindow" | ||
| xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" | ||
| xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" | ||
| xmlns:d="http://schemas.microsoft.com/expression/blend/2008" | ||
| xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006" | ||
| xmlns:pages="using:Microsoft.CmdPal.UI.Pages" | ||
| xmlns:viewmodels="using:Microsoft.CmdPal.UI.ViewModels" | ||
| xmlns:winuiex="using:WinUIEx" | ||
| MinWidth="320" | ||
| MinHeight="240" | ||
| Activated="MainWindow_Activated" | ||
| Closed="MainWindow_Closed" | ||
| mc:Ignorable="d"> | ||
|
|
||
| <pages:ShellPage x:Name="RootShellPage" /> | ||
| </Window> | ||
| </winuiex:WindowEx> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,24 @@ | ||
| <?xml version="1.0" encoding="utf-8" ?> | ||
| <Window | ||
| <winuiex:WindowEx | ||
| x:Class="Microsoft.CmdPal.UI.ToastWindow" | ||
| xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" | ||
| xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" | ||
| xmlns:d="http://schemas.microsoft.com/expression/blend/2008" | ||
| xmlns:local="using:Microsoft.CmdPal.UI" | ||
| xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006" | ||
| xmlns:ui="using:CommunityToolkit.WinUI" | ||
| xmlns:winuiex="using:WinUIEx" | ||
| Title="Command Palette Toast" | ||
| mc:Ignorable="d"> | ||
| <Window.SystemBackdrop> | ||
| <winuiex:WindowEx.SystemBackdrop> | ||
| <DesktopAcrylicBackdrop /> | ||
| </Window.SystemBackdrop> | ||
| </winuiex:WindowEx.SystemBackdrop> | ||
| <Grid x:Name="ToastGrid"> | ||
| <!-- This padding is used to calculate the dimensions of the ToastWindow --> | ||
| <TextBlock | ||
| x:Name="ToastText" | ||
| Padding="16,16,36,24" | ||
| Padding="12,12,24,20" | ||
| Text="{x:Bind ViewModel.ToastMessage, Mode=OneWay}" | ||
| TextAlignment="Center" /> | ||
| </Grid> | ||
| </Window> | ||
| </winuiex:WindowEx> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.