Skip to content

Conversation

@turkerayan
Copy link

@turkerayan turkerayan commented Mar 31, 2025

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

image

Copy link
Collaborator

@htcfreek htcfreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Wrong place and icon for settings.
  2. Duplicate PR.

@turkerayan
Copy link
Author

  1. Wrong place and icon for settings.
  2. Duplicate PR.

#36386 (comment)

This comment indicated that place

@turkerayan
Copy link
Author

@microsoft-github-policy-service agree

@crutkas crutkas added the Needs-Review This Pull Request awaits the review of a maintainer. label Apr 7, 2025
@jamrobot jamrobot requested a review from zhaopy536 April 8, 2025 00:16
@jamrobot jamrobot added the Product-Hosts File Editor Refers to the Hosts file editor label Apr 8, 2025
@jamrobot jamrobot changed the title Adds no whitespace option(#36386) [Hosts] Adds no whitespace option(#36386) Apr 8, 2025
@chenmy77 chenmy77 self-requested a review April 8, 2025 06:21
@crutkas
Copy link
Member

crutkas commented Jul 10, 2025

this and #37852 are trying to solve the same problem

@yeelam-gordon
Copy link
Contributor

@turkerayan, thanks for your PR again.
Sorry that #41206 is checked in, and it should cover this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs-Review This Pull Request awaits the review of a maintainer. Product-Hosts File Editor Refers to the Hosts file editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants