Skip to content

Fix Color Picker resource leak (#38122) #38147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vanzue merged 4 commits into from
Apr 14, 2025
+4 −2
Merged

Fix Color Picker resource leak (#38122) #38147

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ff4723
Fix Color Picker resource leak (#38122)
dcog989 Mar 25, 2025
0d30f20
Fix CI complain
vanzue Mar 27, 2025
79198fa
Merge branch 'microsoft:main' into dcog989-colorpicker-1
dcog989 Mar 27, 2025
51ace6f
Update MouseInfoProvider.cs
dcog989 Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/modules/colorPicker/ColorPickerUI/Mouse/MouseInfoProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,10 @@ private static Color GetPixelColor(System.Windows.Point mousePosition)
var rect = new Rectangle((int)mousePosition.X, (int)mousePosition.Y, 1, 1);
using (var bmp = new Bitmap(rect.Width, rect.Height, PixelFormat.Format32bppArgb))
{
var g = Graphics.FromImage(bmp);
g.CopyFromScreen(rect.Left, rect.Top, 0, 0, bmp.Size, CopyPixelOperation.SourceCopy);
using (var g = Graphics.FromImage(bmp)) // Ensure Graphics object is disposed
{
g.CopyFromScreen(rect.Left, rect.Top, 0, 0, bmp.Size, CopyPixelOperation.SourceCopy);
}

return bmp.GetPixel(0, 0);
}
Expand Down
Loading