[CmdPalette > Time and Date] Custom formats (Port #37743) and other plugin improvements

[htcfreek]

Summary of the Pull Request

This PR ports #37743 to Command Palette module.

Important

• I did not update the spell checker to avoid conflicts with [PT Run > Time and Date plugin] Custom formats and other improvements #37743
• Please merge for the same release as [PT Run > Time and Date plugin] Custom formats and other improvements #37743
• DO NOT MERGE BEFORE [PT Run > Time and Date plugin] Custom formats and other improvements #37743

This PR implements support for custom formats in the "Time and Date" plugin.

And this PR adds support for the following new formats/results:

Format/Result	Input parsing support	Built-in result	Custom format support
Days in month.		x	x
Is leap year.		x
OLE Automation Date	x		x
Excel date value (base 1900)	x		x
Excel date value (base 1904)	x		x

Additionally this PR ...

• reorders settings in the ui.
• removes two settings that make no sense with current CmdPal's behavior.
• improves the way how error details are shown.
• fixes week of month calculation.
• fixes a crash that occurs when converting early dates (e.g. 1.1.100) into windows file time.
• improves error messages for input parsing formats.

PR Checklist

• Closes: [PT Run] [Time and Date plugin] Allow custom format string #16934
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated
• New binaries: Added on the required places
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

• Build and run on my local machine.

[htcfreek]

@zadjii-msft
Can you please help me. The solution doesn't build anymore after changing ResultHelper.cs. And I do not understand why these types are unknown now and can't convert.

[zadjii-msft]

that's weird. It's like the toolkit project wasn't built yet? Sometimes that would happen earlier when the interface changed and we re-generated the winmd, but that hasn't changed since we merged into upstream.

manually clean all the Microsoft.CommandPalette.Extensions.winmd's you find? clean-sdk.ps1 should tidy that up.

I can help more after 0.90 is out.

[zadjii-msft]

blocking for 0.90

[htcfreek]

that's weird. It's like the toolkit project wasn't built yet? Sometimes that would happen earlier when the interface changed and we re-generated the winmd, but that hasn't changed since we merged into upstream.

manually clean all the Microsoft.CommandPalette.Extensions.winmd's you find? clean-sdk.ps1 should tidy that up.

I can help more after 0.90 is out.

@zadjii-msft
Fyi:

• git clean -xfd: Did not solve.
• clean-sdk.ps1: Did not solve.
• Delete local clone and clone again: Did not solve.

[htcfreek]

@zadjii-msft
I fixed the build.

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Copilot]

Copilot reviewed 7 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (3)

• .github/actions/spell-check/expect.txt: Language not supported
• src/modules/cmdpal/Exts/Microsoft.CmdPal.Ext.TimeDate/Properties/Resources.Designer.cs: Language not supported
• src/modules/cmdpal/Exts/Microsoft.CmdPal.Ext.TimeDate/Properties/Resources.resx: Language not supported

Comments suppressed due to low confidence (2)

src/modules/cmdpal/Exts/Microsoft.CmdPal.Ext.TimeDate/Helpers/TimeAndDateHelper.cs:240

• Consider specifying a NumberStyles and CultureInfo (for example, NumberStyles.Float with CultureInfo.InvariantCulture) when calling double.TryParse in the OLE Automation date branch (and similarly in the exc/exf branches) to ensure consistent parsing behavior across different locales.

else if (Regex.IsMatch(input, @"^oa[+-]?\d+[,.0-9]*$") )

src/modules/cmdpal/Exts/Microsoft.CmdPal.Ext.TimeDate/Helpers/AvailableResultsList.cs:100

• [nitpick] The variable 'value' is used both to hold the custom format string and to store the final formatted date. Consider renaming the intermediate variable (e.g. 'customFormat') to improve code clarity.

var value = TimeAndDateHelper.ConvertToCustomFormat(dtObject, unixTimestamp, unixTimestampMilliseconds, weekOfYear, eraShort, Regex.Replace(formatSyntax, "^UTC:", string.Empty), firstWeekRule, firstDayOfTheWeek);

[moooyo]

We are preparing for a fix releasing.

Approve first. But we still need to wait. @htcfreek

[yeelam-gordon]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[htcfreek]

@zadjii-msft
Can you unblock this?

[moooyo]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[moooyo]

@htcfreek could you please merge the main branch?

We renamed the EXT folder to ext.. So there are some conflict.

If it's ready, I'll ping mike to unblock it.

[crutkas]

this has a lot of conflicts now

[htcfreek]

this has a lot of conflicts now

@moooyo , @crutkas
I can't fix this before friday/saturday I think. Definitely not a nice situation now. 😅

[htcfreek]

@crutkas, @moooyo
New PR without conflicts: #38952