[KBM] Simultaneous shortcut invocation in Keyboard Manager

[gokcekantarci]

Summary of the Pull Request

Simultaneous shortcut invoke operations are allowed.

Note: This branch opened from #31923 to avoid code conflicts.

PR Checklist

• Closes: Keyboard manager does not disable hotkeys when they are "rolled" #18459 Modifier key doesn't work when pressing multiple keys at the same time #10393
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated
• New binaries: Added on the required places
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Some unit tests have been changed according to the changes made.

ShortcutDisable_ShouldNotDisableShortcutSuperset_AfterShortcutWasDisabled

• When Ctrl + A invoked those keys are released for invoking shortcut (disabled). After new B key is pressed those are still released.
• Checking Ctrl + B and Ctrl + A + B shortcuts. Those are not exist. So only B key is pressed.
• isShortcutInvoked should be true because we are not resetting that. Because Ctrl, A keys are still pressed.

ShortcutDisable_ShouldResetIsOriginalActionKeyPressed_OnPressingAnotherKey

• Function name and test condition are changed because isOriginalActionKeyPressed is not reset when a new key is pressed after shortcut is invoked.

Validation Steps Performed

The following 3 shortcuts were used while testing:

• Win (Left) + E
• Win (Left) + S
• Win (Left) + V

While testing, all combinations of these shortcuts were tried:

• Win (Left) + E + S
• Win (Left) + E + V
• Win (Left) + S + V
• Win (Left) + S + E
• Win (Left) + V + E
• Win (Left) + V + S
• Win (Left) + E + S + V, V + S + E, S + V + E ...

While testing, the keys were tested with different press, keep pressed and release states:

• Win (Left) + E + Hold V pressed
• Win (Left) + E, release and press V consecutive
• Win (Left) + E, release E, press E, press V
• Win (Left) + E, release E, release Win (Left), press Win (Left) + E + V
• Win (Left) + E + Hold V pressed, release V and E, press V + Hold E pressed
• Win (Left) + release and press(hold or consecutive) different combinations of E + S + V

It was tested by making the following assignments to the shortcuts:

• Win (Left) + E -> Disable

• Win (Left) + S -> Disable

• Win (Left) + V -> Disable

• Win (Left) + E -> A

• Win (Left) + S -> B

• Win (Left) + V -> C

• Win (Left) + E -> Ctrl (Left) + A

• Win (Left) + S -> Ctrl (Left) + V

• Win (Left) + V -> Ctrl (Left) + C

• Win (Left) + E -> Send Text (qwe)

• Win (Left) + S -> Send Text (asd)

• Win (Left) + V -> Send Text (zxc)

• Win (Left) + E -> Run Program (calculator.exe)

• Win (Left) + S -> Run Program (notepad++.exe)

• Win (Left) + V -> Run Program (chrome.exe)

• Win (Left) + E -> Open URI (https://www.google.com/)

• Win (Left) + S -> Open URI (https://github.com/microsoft/PowerToys)

• Win (Left) + V -> Open URI (https://learn.microsoft.com/en-us/windows/win32/inputdev/virtual-key-codes)

It is also tested with common modifier and action keys:

Set shortcuts as below and test shortcuts together

• Ctrl (Left) + A -> Q

• Shift (Left) + A -> W

• Alt (Left) + A -> E

• Ctrl (Left) + Shift (Left) + A -> T

• Ctrl (Left) + Alt (Left) + A -> Y

• Shift (Left) + Alt (Left) + A -> U

• Ctrl (Left) + Shift (Left) + Alt (Left) + A -> J

Please test with Alt gr too.

• Altgr (Ctrl Left + Alt Right) + E

• Altgr (Ctrl Left + Alt Right) + S

• Altgr (Ctrl Left + Alt Right) + V

• Altgr (Ctrl Left + Alt Right) + A -> Q

• Shift Right + A -> W

• Altgr (Ctrl Left + Alt Right) + Shift Right + A -> E

[gokcekantarci]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[stefansjfw]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[stefansjfw]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[gokcekantarci]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Jay-o-Way]

this does actually fix #10393

#18459 (comment)

[bbartels]

@gokcekantarci @stefansjfw Was is blocking this from being merged? Anything I could help out with? Am dying to use this 😄

[andrew-landsverk-win]

Hello! What is the status on this PR? Really looking to use this feature :)

[tonytranwisetech]

Looking forward to this and #32534 to be merged.

[jaimecbernardo]

Gokce is no longer contributing to PowerToys. At the time of developing this code, it created unintended issues.
My review is that it added too much code and added special cases which made the code harder to maintain and created the additional issues. It seems to create many more paths in the code than should be needed to fix this issue. My advise here is to scratch this one and give it another try on a more recent state of the code.