[Deps]Upgrade CppWinRT to 2.0.240111.5 #31396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefansjfw
approved these changes
Feb 13, 2024
Mahfoudh94
added a commit
to Mahfoudh94/PowerToys
that referenced
this pull request
Feb 14, 2024
This reverts commit 5b69243.
11 tasks
jaimecbernardo
added a commit
to Mahfoudh94/PowerToys
that referenced
this pull request
Feb 15, 2024
…)"" This reverts commit 3a23559.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Upgrades CppWinRT to 2.0.240111.5.
Detailed Description of the Pull Request / Additional comments
Found a build regression when trying to update CppWinRT. It's on robmikh.common dependency of CropAndLock.
Created a sample and opened an issue upstream: microsoft/cppwinrt#1391 . I've applied the workaround proposed here, which adds a local substitution of the affected file with some fixes: robmikh/Win32CaptureSample@fc758e3
This PR also adds CppWinRT to CmdNotFoundModuleInterface and EnvironmentVariablesModuleInterface projects, which were missing it.
Validation Steps Performed
Build local installer and sanity checked every utility.
PR CI and release CI both pass.