-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Unicode character for keys in HotkeySettingsControl #2249
Merged
traies
merged 3 commits into
dev/build-features
from
dev/traies/UnicodeInHotkeySettings
Apr 21, 2020
Merged
Display Unicode character for keys in HotkeySettingsControl #2249
traies
merged 3 commits into
dev/build-features
from
dev/traies/UnicodeInHotkeySettings
Apr 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fec7713
to
4955261
Compare
2 tasks
4955261
to
3dc7d47
Compare
f91c9f5
to
420a874
Compare
* A new interop project was setup to provide wrappers for C# projects that want to access functionality in the common project.
420a874
to
92db590
Compare
arjunbalgovind
approved these changes
Apr 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think the Win32 configs are still there in the common-md project, so we should remove that before merging.
337ab59
to
e9c062c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
The
LayoutMap
class fromKeyboardManagerCommon
was moved tocommon
in order to reuse it inHotkeySettingsControl
. In order to call the c++ code from C#, theinterop
project was created, which serves as a C++/CLI wrapper around the native code.References
PR Checklist
Detailed Description of the Pull Request / Additional comments
common
library it wraps around.common
, acommon-md-flag
project was set up that references the same files ascommon
:keyboard_layout.h
,keyboard_layout_impl.h
andkeyboard_layout.cpp
Validation Steps Performed
Manually tested Keyboard Manager works properly, and HotkeySettingsControls as well.