Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added shortcut guide settings #2247

Merged
1 commit merged into from
Apr 20, 2020
Merged

added shortcut guide settings #2247

1 commit merged into from
Apr 20, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 20, 2020

Summary of the Pull Request

Added Shortcut guide settings.

References

PR Checklist

  • Applies to Fluent UX: Settings #889
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • [] Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where a discussion took place: Fluent UX: Settings #889

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@ghost ghost requested review from crutkas, yuyoyuppe, enricogior, niels9001 and a team April 20, 2020 12:01
niels9001
niels9001 approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ghost ghost merged commit cae77ae into dev/build-features Apr 20, 2020
@crutkas crutkas deleted the user/lamotile/shortcut_guides_plustests branch April 24, 2020 18:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crutkas crutkas Awaiting requested review from crutkas

@yuyoyuppe yuyoyuppe Awaiting requested review from yuyoyuppe

@enricogior enricogior Awaiting requested review from enricogior

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@niels9001