Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FileLocksmith]Fix crash while opening process handlers #21602

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

jaimecbernardo
Copy link
Collaborator

Summary of the Pull Request

Fix crashes that were occurring when a process exited after we recognized it but before we added a watcher to check when it exited.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Actually handle exceptions when getting the process handles and log them.
Remove the DataBinding on IsExpanded. It's not working and is filling the logs with useless information.

Validation Steps Performed

Tested on PCs where the crash was easily reproducible.

Copy link
Collaborator

@stefansjfw stefansjfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't reproduce the crash before, but change looks good to me.

Copy link
Collaborator

@SeraphimaZykova SeraphimaZykova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, the issue is fixed!

@jaimecbernardo jaimecbernardo merged commit 7b77427 into main Nov 2, 2022
@jaimecbernardo
Copy link
Collaborator Author

This solves: #21583

@jaimecbernardo jaimecbernardo deleted the dev/jaime/fix-filelocksmith-crash branch November 2, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants