Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Screen Ruler] Fix possible crash in CaptureSingleFrame #20275

Merged
merged 1 commit into from
Sep 5, 2022
Merged

[Screen Ruler] Fix possible crash in CaptureSingleFrame #20275

merged 1 commit into from
Sep 5, 2022

Conversation

yuyoyuppe
Copy link
Contributor

Summary of the Pull Request

PR Checklist

  • Closes: Screen measuring tool #863
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

jaimecbernardo
jaimecbernardo approved these changes Sep 5, 2022
View reviewed changes
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work!

stefansjfw
stefansjfw approved these changes Sep 5, 2022
View reviewed changes
Copy link
Collaborator

@stefansjfw stefansjfw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works good. 4k monitor works fluently as well

@yuyoyuppe yuyoyuppe merged commit feead9c into microsoft:main Sep 5, 2022
@yuyoyuppe yuyoyuppe deleted the fix_possible_crash branch September 5, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefansjfw stefansjfw stefansjfw approved these changes

@jaimecbernardo jaimecbernardo jaimecbernardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuyoyuppe @jaimecbernardo @stefansjfw