Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Fix wix warnings introduced by MeasureTool #20188

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

stefansjfw
Copy link
Collaborator

Summary of the Pull Request

Not the nicest change there is but I'd prefer this rather than disabling warnings.

PR Checklist

  • Closes: Screen measuring tool #863
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copy link
Contributor

@yuyoyuppe yuyoyuppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefansjfw stefansjfw merged commit fcfbb67 into main Aug 31, 2022
@stefansjfw stefansjfw deleted the stefan/wix_warnings branch August 31, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants