Move to WinAppSDK-1.1.0 #18603

stefansjfw · 2022-06-03T23:40:54Z

Summary of the Pull Request

note: Removed PowerRename method was breaking the build because of the unresolved reference. Method is not needed, therefore deleted.

Someone please test ARM64 installer.
What is this about:

What is included in the PR:

How does someone test / validate:

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

htcfreek · 2022-06-04T09:24:52Z

Does this fix some of the settings bugs?

Jay-o-Way · 2022-06-04T12:50:21Z

Is this able to hop on .59 or has that train already left the station?

jaimecbernardo · 2022-06-04T15:10:57Z

Does this fix some of the settings bugs?

It will fix the "unable to run elevated" issue so many people are having.

jaimecbernardo · 2022-06-04T15:11:18Z

Is this able to hop on .59 or has that train already left the station?

Yes, this is what we were waiting for to include in .59 .

src/modules/powerrename/lib/PowerRenameInterfaces.h

crutkas · 2022-06-04T15:25:44Z

src/modules/powerrename/lib/PowerRenameItem.cpp

@@ -180,16 +179,6 @@ IFACEMETHODIMP CPowerRenameItem::GetId(_Out_ int* id)
    return S_OK;
 }



Why was this removed? Wouldn’t expect it in a rev for 1.1

From the PR description. Looks like it isn't used and breaks the build.

Removed PowerRename method was breaking the build because of the unresolved reference. Method is not needed, therefore deleted.

crutkas · 2022-06-04T15:27:38Z

src/settings-ui/Settings.UI/GlobalSuppressions.cs

@@ -73,3 +73,8 @@
 [assembly: SuppressMessage("StyleCop.CSharp.MaintainabilityRules", "SA1402:File may only contain a single type", Justification = "Not part of the project. WindowsAppSDK file.", Scope = "type", Target = "~T:Microsoft.WindowsAppSDK.Runtime.Packages.Singleton")]
 [assembly: SuppressMessage("StyleCop.CSharp.LayoutRules", "SA1516:Elements should be separated by blank line", Justification = "Not part of the project. WindowsAppSDK file.", Scope = "type", Target = "~T:Microsoft.WindowsAppSDK.Runtime.Packages.Singleton")]
 [assembly: SuppressMessage("StyleCop.CSharp.LayoutRules", "SA1516:Elements should be separated by blank line", Justification = "Not part of the project. WindowsAppSDK file.", Scope = "type", Target = "~T:Microsoft.WindowsAppSDK.Runtime.Packages.Main")]
+[assembly: SuppressMessage("StyleCop.CSharp.LayoutRules", "SA1513:Closing brace should be followed by blank line", Justification = "Not part of the project. WindowsAppSDK file.", Scope = "namespaceanddescendants", Target = "Microsoft.WindowsAppSDK.Runtime.Packages")]


These are pretty important rules. Can we maybe target the offending file or method?

I wouldn’t block the release on this but would be nice to adjust

The target part means these exceptions will be applied to the offending package. They'll still trigger in our code.
Regarding the copyright one, I think that could only be done locally in the file for it to be specific ... It's code from nuget, though. It's possible to make that one only apply to the Settings project, so I guess that's what we'll do.

This reverts commit c485da2.

jaimecbernardo

Tested and it looks good. No longer has the run elevation issue with 1.1.
I've added a commit to revert the change where we were showing a warning instead of starting Settings under those conditions.
Great work.

davidegiacometti · 2022-06-04T19:17:48Z

Don't want to bother but both Settings and PowerRename are not starting after a clean build.
The error is 0xc0000005 access violation.
Could be my machine but never had any issue with SDK 1.0.3.

jaimecbernardo · 2022-06-04T20:20:12Z

Don't want to bother but both Settings and PowerRename are not starting after a clean build. The error is 0xc0000005 access violation. Could be my machine but never had any issue with SDK 1.0.3.

Wow. That's pretty weird. Any other info there? Like a call stack from VS?

davidegiacometti · 2022-06-04T20:27:36Z

Looks like the error is on Microsoft.WindowsAppRuntime.Bootstrap.Net.dll side.
Can I help somehow?

System.AccessViolationException
  HResult=0x80004003
  Message=Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
  Source=<Cannot evaluate the exception source>
  StackTrace:
<Cannot evaluate the exception stack trace>

jaimecbernardo · 2022-06-04T21:03:02Z

@davidegiacometti You've installed winappsdk 1.1, right? Any errors in the command line when installing it?
https://aka.ms/windowsappsdk/1.1/1.1.0/windowsappruntimeinstall-1.1.0-x64.exe

Did you restart after?

This is pretty weird.
Do you have event viewer events? I'm thinking creating an issue like this might help, which is a similar error but the exception code is different: microsoft/WindowsAppSDK#2573

Does the WinUI 3 Gallery from the store also crash in a similar fashion?

jaimecbernardo · 2022-06-04T21:09:32Z

@davidegiacometti , this issue microsoft/WindowsAppSDK#2492 seems to indicate somethings might need to be cleaned up. Can you try to really clean the repo with git clean -ffxd and trying to build again?

davidegiacometti · 2022-06-04T21:20:07Z

I agree that's really strange.

I have installed 1.1 runtime and both VS extensions (C# and C++).
Now I have:

Rebooted again
git clean -ffxd
Rebuild
Same error

I am also experiencing the error with WinUI 3 Gallery.

davidegiacometti · 2022-06-04T21:50:17Z

I have been able to fix it:

Removed all App SDK installations: 0.8, 1.0.3, several 1.1 previews.
Rebooted
Reinstalled 1.0.3 and 1.1
Everything works

I think the build was failing becouse of 1.1 previews installed.

jaimecbernardo · 2022-06-04T22:29:51Z

Thanks for the heads-up @davidegiacometti . This is something I definitely want to repro locally to open an issue upstream.

* Move to WinAppSDK-1.1.0 * expect.txt * Revert "[Settings]Don't launch if explorer is running elevated" This reverts commit c485da2. * Make copyright header analyze suppression module scope

davidegiacometti · 2022-06-06T15:39:26Z

Global suppressions can be reverted after microsoft/WindowsAppSDK#2569

Move to WinAppSDK-1.1.0

2ab94a9

stefansjfw requested review from yuyoyuppe and jaimecbernardo June 3, 2022 23:40

expect.txt

cd269c0

stefansjfw force-pushed the stefan/winappsdk1_1 branch from 7b47f98 to cd269c0 Compare June 3, 2022 23:42

Jay-o-Way mentioned this pull request Jun 4, 2022

0.59 changelog #18575

Merged

crutkas reviewed Jun 4, 2022

View reviewed changes

src/modules/powerrename/lib/PowerRenameInterfaces.h Show resolved Hide resolved

crutkas reviewed Jun 4, 2022

View reviewed changes

crutkas approved these changes Jun 4, 2022

View reviewed changes

jaimecbernardo added 2 commits June 4, 2022 16:54

Revert "[Settings]Don't launch if explorer is running elevated"

41dbe06

This reverts commit c485da2.

Make copyright header analyze suppression module scope

de7317f

jaimecbernardo approved these changes Jun 4, 2022

View reviewed changes

jaimecbernardo merged commit 97be8db into main Jun 4, 2022

rocksdanister mentioned this pull request Jun 5, 2022

WinAppSDK v1.1.0 throws System.AccessViolationException on Unpackaged WinUI 3 apps microsoft/WindowsAppSDK#2578

Closed

jaimecbernardo deleted the stefan/winappsdk1_1 branch June 14, 2022 23:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move to WinAppSDK-1.1.0 #18603

Move to WinAppSDK-1.1.0 #18603

stefansjfw commented Jun 3, 2022 •

edited by jaimecbernardo

Loading

htcfreek commented Jun 4, 2022

Jay-o-Way commented Jun 4, 2022

jaimecbernardo commented Jun 4, 2022

jaimecbernardo commented Jun 4, 2022

crutkas Jun 4, 2022

jaimecbernardo Jun 4, 2022

crutkas Jun 4, 2022

crutkas Jun 4, 2022

jaimecbernardo Jun 4, 2022

jaimecbernardo left a comment

davidegiacometti commented Jun 4, 2022

jaimecbernardo commented Jun 4, 2022

davidegiacometti commented Jun 4, 2022

jaimecbernardo commented Jun 4, 2022

jaimecbernardo commented Jun 4, 2022

davidegiacometti commented Jun 4, 2022

davidegiacometti commented Jun 4, 2022

jaimecbernardo commented Jun 4, 2022

davidegiacometti commented Jun 6, 2022

		@@ -180,16 +179,6 @@ IFACEMETHODIMP CPowerRenameItem::GetId(_Out_ int* id)
		return S_OK;
		}

Move to WinAppSDK-1.1.0 #18603

Move to WinAppSDK-1.1.0 #18603

Conversation

stefansjfw commented Jun 3, 2022 • edited by jaimecbernardo Loading

Summary of the Pull Request

Quality Checklist

Contributor License Agreement (CLA)

htcfreek commented Jun 4, 2022

Jay-o-Way commented Jun 4, 2022

jaimecbernardo commented Jun 4, 2022

jaimecbernardo commented Jun 4, 2022

crutkas Jun 4, 2022

Choose a reason for hiding this comment

jaimecbernardo Jun 4, 2022

Choose a reason for hiding this comment

crutkas Jun 4, 2022

Choose a reason for hiding this comment

crutkas Jun 4, 2022

Choose a reason for hiding this comment

jaimecbernardo Jun 4, 2022

Choose a reason for hiding this comment

jaimecbernardo left a comment

Choose a reason for hiding this comment

davidegiacometti commented Jun 4, 2022

jaimecbernardo commented Jun 4, 2022

davidegiacometti commented Jun 4, 2022

jaimecbernardo commented Jun 4, 2022

jaimecbernardo commented Jun 4, 2022

davidegiacometti commented Jun 4, 2022

davidegiacometti commented Jun 4, 2022

jaimecbernardo commented Jun 4, 2022

davidegiacometti commented Jun 6, 2022

stefansjfw commented Jun 3, 2022 •

edited by jaimecbernardo

Loading