-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PowerRename] Tweak UI and fix performance issues #14365
Conversation
Gave it a try. A folder with >5000 files loaded in what it seemed to be an instant. Definitely fixes the performance issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Implementation looks simpler, as well.
Great work!
Let's get another review here before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, with 5000 it works perfectly.
Also tried a stress test with 60000 files. Of course, it takes time, but at least it opens and shows all of them. Trying to rename or filter them leads to PowerRename crash, but the old version crashed already on start with this amount.
Summary of the Pull Request
Co-Authored by: @niels9001
What is this about:
Tweaking UI according to users feedback:
Resolved poor performance issues caused by virtualization and nested ListViews
Previous UI vs. new UI:

Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.