Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerRename] Tweak UI and fix performance issues #14365

Merged
merged 14 commits into from
Nov 17, 2021

Conversation

stefansjfw
Copy link
Contributor

@stefansjfw stefansjfw commented Nov 10, 2021

Summary of the Pull Request

Co-Authored by: @niels9001

What is this about:

  1. Tweaking UI according to users feedback:

    • Reduced fontsizes & margins
    • Added the number of items selected (next to the 'Original' header) and items to be renamed (next to the 'Renamed' header)
    • Added gridlines to improve readability.
    • Resizing both Original and Renamed columns on window resize
  2. Resolved poor performance issues caused by virtualization and nested ListViews

Previous UI vs. new UI:
DensePowerRename

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@Dzomlija
Copy link

Here is a screenshot of how the Original filename column is cut-off if the filename is exceptionally long:
image

@jaimecbernardo
Copy link
Collaborator

Gave it a try. A folder with >5000 files loaded in what it seemed to be an instant. Definitely fixes the performance issues.

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Implementation looks simpler, as well.
Great work!
Let's get another review here before merging.

Copy link
Collaborator

@SeraphimaZykova SeraphimaZykova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, with 5000 it works perfectly.

Also tried a stress test with 60000 files. Of course, it takes time, but at least it opens and shows all of them. Trying to rename or filter them leads to PowerRename crash, but the old version crashed already on start with this amount.

@stefansjfw stefansjfw merged commit 5a4822f into main Nov 17, 2021
@stefansjfw stefansjfw deleted the stefan/performance_work branch November 17, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants