Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User/lamotile/add powerlauncher project #1287

Merged
5 commits merged into from
Feb 13, 2020

Conversation

ghost
Copy link

@ghost ghost commented Feb 12, 2020

Summary of the Pull Request

Create a base PowerToys PowerLauncher project as in the PowerToys_Example project. This should contain an empty PowertOToys module that implements the PowerToys Module Interface with empty settings and empty test project.

DoD:
We have a C++ PowerLaunchy Dummy Project.
PowerLauncher now shows in PowerToys Settings.
We have a test Project for PowerLauncher.
The Code is reviewed and in feature branch.

References

PR Checklist

  • Applies to Win+R replacement #44
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: Win+R replacement #44

Validation Steps Performed

  • Ran all tests and verified output in the UI.

@ghost ghost removed the request for review from bzoz February 12, 2020 21:25
Copy link
Contributor

@alekhyareddy28 alekhyareddy28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@bkudiess bkudiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 3785fad into dev/PowerLauncher Feb 13, 2020
@ghost ghost deleted the user/lamotile/add_powerlauncher_project branch February 13, 2020 18:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants