Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerToys Run] Update to net5 #12434

Merged
merged 4 commits into from
Jul 21, 2021
Merged

[PowerToys Run] Update to net5 #12434

merged 4 commits into from
Jul 21, 2021

Conversation

mykhailopylyp
Copy link
Contributor

Summary of the Pull Request

What is this about:

What is include in the PR:

How does someone test / validate:

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

yuyoyuppe and others added 3 commits July 12, 2021 13:37
* Change targets of projects

* Update Microsoft.Toolkit.Uwp.Notifications,

changed TargetFramework for PowerLauncher project in order to resolve an issue with ModernWpf

* Specify windows version in order to fix build errors

* Fixed suppressed warnings

* Updated sdk

* Removed usage of obsolete GlobalAssemblyCache

* Removed obsolete DesktopNotificationManagerCompat

* Update nuget versions

* Update installer
* Change targets of projects

* Update Microsoft.Toolkit.Uwp.Notifications,

changed TargetFramework for PowerLauncher project in order to resolve an issue with ModernWpf

* Fixed suppressed warnings

* Removed obsolete DesktopNotificationManagerCompat

* Get rid of binary formatter

* Update tests

* Don't include new image cache file to the report

* There's no need to call IsOwner as it doesn't make sense

* Fix different nullability exception
@mykhailopylyp mykhailopylyp added Product-PowerToys Run Improved app launch PT Run (Win+R) Window Area-Setup/Install Refers to installation mechanism labels Jul 20, 2021
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Great work!

@jaimecbernardo jaimecbernardo self-requested a review July 21, 2021 14:11
@jaimecbernardo
Copy link
Collaborator

Actually, wait a bit on this one, please.

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind. I was detecting an issue. But it's there on master as well.
It's good to go.

@mykhailopylyp mykhailopylyp merged commit c651a4b into master Jul 21, 2021
@mykhailopylyp mykhailopylyp deleted the feature/pt-run-net5 branch July 21, 2021 16:02
@mykhailopylyp mykhailopylyp restored the feature/pt-run-net5 branch July 28, 2021 09:46
mykhailopylyp added a commit to mykhailopylyp/PowerToys that referenced this pull request Jul 28, 2021
jaimecbernardo pushed a commit that referenced this pull request Jul 28, 2021
@crutkas crutkas deleted the feature/pt-run-net5 branch September 2, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Setup/Install Refers to installation mechanism Product-PowerToys Run Improved app launch PT Run (Win+R) Window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants