Migrate FancyZones data persisting from Registry to JSON file#1194

Merged

stefansjfw merged 32 commits intomicrosoft:masterfrom stefansjfw:json-migration

Feb 10, 2020

+8,475-1,884

Commits on Feb 10, 2020

Migrate FancyZones data persisting from Registry to JSON file

stefansjfw
authored and
SeraphimaZykova
committed
Address PR comment: Remove redundant check

stefansjfw
authored and
SeraphimaZykova
committed
Addres PR comment: Remove unused Dpi and add CmdArgs enum

stefansjfw
authored and
SeraphimaZykova
committed
Address PR comment: Make methods const and inline

stefansjfw
authored and
SeraphimaZykova
committed
Address PR comments: Expose GenerateUniqueId function and use const ref instead of passing wstring by value

vldmr11080
authored and
SeraphimaZykova
committed
Address PR comment: Use lamdba as callback

stefansjfw
authored and
SeraphimaZykova
committed
Address PR comment: Move GenerateUniqueId to ZoneWindowUtils namespace

vldmr11080
authored and
SeraphimaZykova
committed
Address PR comment: Use regular comparison instead of std::wstring::compare

vldmr11080
authored and
SeraphimaZykova
committed
Address PR comment: Use std::wstring_view for tmp file paths

vldmr11080
authored and
SeraphimaZykova
committed
Address PR comment: Use scoped lock when accessing member data

vldmr11080
authored and
SeraphimaZykova
committed
Address PR comment: Remove typedefs to increase code readability

vldmr11080
authored and
SeraphimaZykova
committed
Address PR comment: removed nullptr checks with corresponding tests
SeraphimaZykova
committed
Address PR comment: Move ZoneSet object instead of copying

vldmr11080
authored and
SeraphimaZykova
committed
Address PR comment: Make FancyZonesData instance const where possible

stefansjfw
authored and
SeraphimaZykova
committed
Remove unnecessary gutter variable during calculating zone coordinates

vldmr11080
authored and
SeraphimaZykova
committed
Remove uneeded subclass

stefansjfw
authored and
SeraphimaZykova
committed
Avoid unnecessary copying and reserve space for vector if possible

vldmr11080
authored and
SeraphimaZykova
committed
Save FancyZones data after exiting editor

vldmr11080
authored and
SeraphimaZykova
committed
App zone history (#18 )
SeraphimaZykova
committed
Rename JSON file

stefansjfw
authored and
SeraphimaZykova
committed
Remove AppZoneHistory migration

stefansjfw
authored and
SeraphimaZykova
committed
Move parsing of ZoneWindow independent temp files outside of it

vldmr11080
authored and
SeraphimaZykova
committed
Unit tests update (#19 )
SeraphimaZykova
committed
Use single zone count information

stefansjfw
authored and
SeraphimaZykova
committed
Remove uneeded tests

stefansjfw
authored and
SeraphimaZykova
committed
Remove one more test

stefansjfw
authored and
SeraphimaZykova
committed
Remove uneeded line

stefansjfw
authored and
SeraphimaZykova
committed
Address PR comments - Missing whitespace

stefansjfw
authored and
SeraphimaZykova
committed
Update zoneset data for new virtual desktops (#21 )
SeraphimaZykova
committed
Introduce Blank zone set (used to indicate that no layout applied yet). Move parsing completely outside of ZoneWindow.

vldmr11080
authored and
SeraphimaZykova
committed
Fix unit tests to match modifications in implementation

vldmr11080
authored and
SeraphimaZykova
committed
Fix applying layouts on startup (second monitor)

stefansjfw
authored and
SeraphimaZykova
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate FancyZones data persisting from Registry to JSON file#1194

Commits on Feb 10, 2020

Migrate FancyZones data persisting from Registry to JSON file

Address PR comment: Remove redundant check

Addres PR comment: Remove unused Dpi and add CmdArgs enum

Address PR comment: Make methods const and inline

Address PR comments: Expose GenerateUniqueId function and use const ref instead of passing wstring by value

Address PR comment: Use lamdba as callback

Address PR comment: Move GenerateUniqueId to ZoneWindowUtils namespace

Address PR comment: Use regular comparison instead of std::wstring::compare

Address PR comment: Use std::wstring_view for tmp file paths

Address PR comment: Use scoped lock when accessing member data

Address PR comment: Remove typedefs to increase code readability

Address PR comment: removed nullptr checks with corresponding tests

Address PR comment: Move ZoneSet object instead of copying

Address PR comment: Make FancyZonesData instance const where possible

Remove unnecessary gutter variable during calculating zone coordinates

Remove uneeded subclass

Avoid unnecessary copying and reserve space for vector if possible

Save FancyZones data after exiting editor

App zone history (#18 )

Rename JSON file

Remove AppZoneHistory migration

Move parsing of ZoneWindow independent temp files outside of it

Unit tests update (#19 )

Use single zone count information

Remove uneeded tests

Remove one more test

Remove uneeded line

Address PR comments - Missing whitespace

Update zoneset data for new virtual desktops (#21 )

Introduce Blank zone set (used to indicate that no layout applied yet). Move parsing completely outside of ZoneWindow.

Fix unit tests to match modifications in implementation

Fix applying layouts on startup (second monitor)