Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ActionKeyword for Running processes #5823

Closed
Just1n opened this issue Aug 10, 2020 · 7 comments
Closed

add ActionKeyword for Running processes #5823

Just1n opened this issue Aug 10, 2020 · 7 comments
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Help Wanted

Comments

@Just1n
Copy link

Just1n commented Aug 10, 2020

📝 Add a filter for PowerToys Run for switching APPs

Challenge from AS-IS

When I click 'Alt + Space', a box popped, and I want to switch to another running process (e.g. teams), I type 'teams', the first item is always lunching Teams.
image

Recommendation

Add a filter, e.g. keyword 'r' + space means I only want to search the running processes and switch to the selected one.
e.g. I type 'r teams', and press Enter, then I switch from Chrome to Teams.
PS. Switcheroo (it's dead now. :( ) is a perfect Alt+Tab alternative. You can refer to it.
image

👍 👍
@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Aug 10, 2020
@crutkas crutkas changed the title Filter for PowerToys Run add ActionKeyword for Running processes Aug 14, 2020
@crutkas
Copy link
Member

crutkas commented Aug 14, 2020

I think this is a good idea, i we also need another superset item of allowing plugins to run but not return values by default.

I think we need to figure out action keywords across all plugins as well so we can see possible conflicts and what 'feels' natural for a default value.

@crutkas crutkas added Idea-Enhancement New feature or request on an existing product Product-PowerToys Run Improved app launch PT Run (Win+R) Window and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Aug 14, 2020
@crutkas crutkas added this to the Suggested Enhancements milestone Aug 14, 2020
@crutkas crutkas added the Help Wanted We encourage anyone to jump in on these and submit a PR. label Aug 14, 2020
@crutkas
Copy link
Member

crutkas commented Aug 14, 2020

this should be as easy as adding it to the plugin.json actionkeyword json file. but the bigger work item is the 2nd point

@Just1n
Copy link
Author

Just1n commented Aug 15, 2020

@crutkas The app (Switcheroo) I mentioned has another feature, when an item is selected I press 'CTRL + Enter' this running process will be terminated. Can this functionality be also added to PT run?

@crutkas
Copy link
Member

crutkas commented Aug 21, 2020

@crutkas The app (Switcheroo) I mentioned has another feature, when an item is selected I press 'CTRL + Enter' this running process will be terminated. Can this functionality be also added to PT run?

@Just1n please file a new issue, single ask per issue.

@Just1n Just1n mentioned this issue Aug 21, 2020
Closed
gordonwatts added a commit to gordonwatts/PowerToys that referenced this issue Aug 23, 2020
@gordonwatts
Add action keywords for each plugin
b5bd3fd 
- Added keywords for each plug-in
-  Change window walker search to use Query, not RawQuery (to get rid of action keyword)
- Make sure plug-ins that have action keywords as well as are in global list don't get added twice

All tests passed that passed before I started

Addressing issue microsoft#5823
@gordonwatts gordonwatts mentioned this issue Aug 23, 2020
Merged
5 tasks
@crutkas crutkas mentioned this issue Sep 3, 2020
Closed
@crutkas
Copy link
Member

crutkas commented Sep 15, 2020

incase others haven't seen this, @gordonwatts did a great job of adding in action words. Highly suggest people look at the feedback and would love thoughts.

#6129 (comment)

@htcfreek htcfreek mentioned this issue Oct 16, 2020
Closed
crutkas pushed a commit that referenced this issue Oct 19, 2020
@gordonwatts
Add action keywords for each plugin (#6129)
4660dd4 
* Add action keywords for each plugin

- Added keywords for each plug-in
-  Change window walker search to use Query, not RawQuery (to get rid of action keyword)
- Make sure plug-ins that have action keywords as well as are in global list don't get added twice

All tests passed that passed before I started

Addressing issue #5823

* Fix bad formatting from the merge

* Do not add global plug-ins if we have an action keyword

Note side effect: you will not not be able to search for things that start with one of the plug-in keywords.

* Missed merge conflict repair!

* Revert "Do not add global plug-ins if we have an action keyword"

This reverts commit e3b0ecd.

* Adjust keywords to suggested ones

* No need to ubild a query if we aren't going to use it

Didn't quite get the if statement right the first time I put it in.

* Do not add global plugins if we have an action keyword

This means, especially without a space, that global plugins do not become part of the search. Which really narrows down the search results, nicely.

* Update keywords as requested in the PR
@crutkas crutkas added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Oct 19, 2020
@crutkas
Copy link
Member

crutkas commented Oct 19, 2020

Great PR by @gordonwatts!!! This will be in the 0.25 release due at the end of October.

@crutkas
Copy link
Member

crutkas commented Oct 29, 2020

In the 0.25 release. https://github.com/microsoft/PowerToys/releases/tag/v0.25.0

@crutkas crutkas closed this as completed Oct 29, 2020
@github-project-automation github-project-automation bot moved this to ⚠️Needs Walkthrough in 3. Help Wanted Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
3. Help Wanted
Status: ⚠️Needs Walkthrough
Milestone
Help Wanted
Development

No branches or pull requests
2 participants
@Just1n @crutkas