Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rows template: Gap between window and taskbar even with space set to 0 #286

Closed
AkazaRenn opened this issue Sep 7, 2019 · 2 comments
Closed

Rows template: Gap between window and taskbar even with space set to 0 #286

AkazaRenn opened this issue Sep 7, 2019 · 2 comments
Labels
Area-Quality Stability, Performance, Etc. Issue-Bug Something isn't working Priority-3 Bug that is low priority Product-FancyZones Refers to the FancyZones PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@AkazaRenn
Copy link

AkazaRenn commented Sep 7, 2019 •
edited
Loading

Environment

Windows build number: 18362.329
PowerToys version: 0.11.0
PowerToy module for which you are reporting the bug (if applicable): FancyZones

Steps to reproduce

Apply layout Rows with number set to 3 and space around zones set to 0

Expected behavior

No gap between the bottom window and taskbar or at least not larger than the gap between windows

Actual behavior

Gap between the bottom window and taskbar:
image

Gap between windows:
image
@AkazaRenn AkazaRenn changed the title Gap between window and taskbar even set the space around zones to 0 Gap between window and taskbar too large even set the space around zones to 0 Sep 7, 2019
@enricogior enricogior added Idea-Enhancement New feature or request on an existing product Product-FancyZones Refers to the FancyZones PowerToy labels Sep 8, 2019
@jayellsworth
Copy link

I'm seeing the same issue, specifically can't seem to get the first zone to not have a gap. Subsequent zones have no gaps.

@enricogior enricogior changed the title Gap between window and taskbar too large even set the space around zones to 0 Rows template: Gap between window and taskbar even with space set to 0 Mar 3, 2020
@enricogior enricogior added Issue-Bug Something isn't working Priority-3 Bug that is low priority Area-Quality Stability, Performance, Etc. and removed Idea-Enhancement New feature or request on an existing product labels Mar 3, 2020
@enricogior enricogior mentioned this issue Mar 5, 2020
Closed
@ivan100sic ivan100sic mentioned this issue Mar 5, 2020
Merged
3 tasks
@enricogior enricogior added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Mar 23, 2020
@ivan100sic ivan100sic mentioned this issue Mar 23, 2020
Closed
@enricogior
Copy link
Contributor

The fix is now available in 0.16 https://github.com/microsoft/PowerToys/releases

davidegiacometti pushed a commit to davidegiacometti/PowerToys that referenced this issue Jan 26, 2025
@zadjii-msft
Allow both light and dark icons (microsoft#286)
2efdbb6 
This adds one _last_ change to the API to allow apps to specify different icons for light and dark mode. 

If it's important to an app to specify different icons for light vs dark mode, then `IconInfo` is exactly what you want to use. It contains _two_ `IconDataType`s, for two different icons. Simple as that. 

And to keep things even easier, I slapped on a `IconInfo(string)` constructor, so that you can easily build a `IconInfo` with both icons set to the same string. Especially useful for font icons, which we're using everywhere already. That allows almost all the extensions to have _no code change_ here, so that's super!

Some of the places where we were evaluating if an icon existed or not - that needs to move into the view. `ShellPage.xaml.cs` does one variant of that already for `IDetails.HeroImage`. The view is the only part of the app that knows what the theme is. 

Closes microsoft#78
davidegiacometti pushed a commit to davidegiacometti/PowerToys that referenced this issue Jan 26, 2025
@zadjii-msft
Fix FontIcon padding, again (microsoft#308)
e0e13f5 
When we changed icons to be a pair of IconData in an IconInfo, I forgot this type check.
Oops. Now it works again.

Originally in microsoft#265 
Regressed in microsoft#286 

(targets microsoft#308, which targets microsoft#299)

`IconData` and `IconInfo` are unfortunately, not trivially marshallable into the host process. This creates a collection of cases where an app can crash and take the host down, because we'll try to inquire something about the icon. 

It broke reloading when an extension crashed. 
It broke backing out of a crashed extension. 


Previously: microsoft#218 
Closes microsoft#235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Quality Stability, Performance, Etc. Issue-Bug Something isn't working Priority-3 Bug that is low priority Product-FancyZones Refers to the FancyZones PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@enricogior @AkazaRenn @jayellsworth