Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color picker returns incorrect values when an icc color profile is used on monitor #11585

Open
1 task done
nicolasprigent opened this issue Jun 3, 2021 · 8 comments
Open
1 task done
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Product-Color Picker All things around the Color Picker utility

Comments

@nicolasprigent
Copy link

nicolasprigent commented Jun 3, 2021

Microsoft PowerToys version

0.37.2

Running as admin

  • Yes

Area(s) with issue?

ColorPicker

Steps to reproduce

If your monitor has an icc profile applied, the return values differs from what is actually stored in the program that displays the color.

✔️ Expected Behavior

It seems to be a problem on screenshots in general and I guess color picker uses screenshot functionnality at some point. If I do a screenshot when having an icc profile, I have to go to photoshop and assign my icc monitor profile on the image, then convert to srgb to get the good values back.

There should be 2 options for icc profile for color picker :

  • 1 to set the icc profile of the monitor
  • 1 to choose the desired icc profile for output the value (srgb by default I guess).

The value displayed in the color picker would be first assigned in the color space of the monitor then converted to the output icc profile choosen.

As a bonus, there should be an hotkey to do this color assign/convert to images in the clipboard. So you can make a screenshot, do the color correction with hotkey directly in the clipboard, then just paste the image in the document.

❌ Actual Behavior

As an example I color picked the red "Issue-Bug" label on the right of this bug report.

The color picked value is returned as : rgb(199, 55, 23)
But in the source of the page, the correct value is : rgb(230, 0, 0)

Other Software

No response

@nicolasprigent nicolasprigent added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jun 3, 2021
@niels9001
Copy link
Contributor

@martinchrzan could this be an API/platform limitation?

@martinchrzan
Copy link
Contributor

Yep it is, we are using the same API as the regular print screen functionality. We would have to read the current color profiles for the current screen and do a conversion. Doable, but quite a lot of work.

@nicolasprigent
Copy link
Author

nicolasprigent commented Jun 3, 2021

Well, people that uses color profiles on their monitor are people that are expecting correct colors in the entire workflow. This makes the color picker unusable for me.
But yes, it's clearly not just this tool that would need the correction. I've got this problem with screenshot programs (lightshot or built-in screenshot program in windows). I guess it's maybe more something that should be fixed directly in the OS.
For people like me that works on webdesign, or have to make documentations about programs, I have to rework all my screenshots before pasting them in word for example. And if I paste screenshots directly into emails, I often get "the colors are wrong" as the only response :) .

@nicolasprigent
Copy link
Author

I've made a bug report on windows 10 feedback hub also. I hope this will be seen among all other suggestions that there is.

@nicolasprigent
Copy link
Author

Here is the bug report (it opens feedback hub app on windows 10) : https://aka.ms/AActizq

@crutkas
Copy link
Member

crutkas commented Jun 8, 2021

it is a known limitation as of now as @martinchrzan stated. If it is a system wide color profile, we may be able to tweak.

@crutkas crutkas added Idea-Enhancement New feature or request on an existing product Product-Color Picker All things around the Color Picker utility Help Wanted We encourage anyone to jump in on these and submit a PR. and removed Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jun 8, 2021
@arafathossainadi
Copy link

I have realized that the ICC profile of my primary monitor was causing this issue. So while picking colors I drag the reference color to secondary monitor and then use the color picker to pick the accurate hex code.

@PesBandi
Copy link
Contributor

Hi @niels9001, I have a quick UX question for you. What's your opinion on adding a warning to the Color Picker settings page that says something along the lines of "Color Picker may be inaccurate if you use a color profile"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Product-Color Picker All things around the Color Picker utility
Projects
Status: No status
Development

No branches or pull requests

6 participants