-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color picker returns incorrect values when an icc color profile is used on monitor #11585
Comments
@martinchrzan could this be an API/platform limitation? |
Yep it is, we are using the same API as the regular print screen functionality. We would have to read the current color profiles for the current screen and do a conversion. Doable, but quite a lot of work. |
Well, people that uses color profiles on their monitor are people that are expecting correct colors in the entire workflow. This makes the color picker unusable for me. |
I've made a bug report on windows 10 feedback hub also. I hope this will be seen among all other suggestions that there is. |
Here is the bug report (it opens feedback hub app on windows 10) : https://aka.ms/AActizq |
it is a known limitation as of now as @martinchrzan stated. If it is a system wide color profile, we may be able to tweak. |
I have realized that the ICC profile of my primary monitor was causing this issue. So while picking colors I drag the reference color to secondary monitor and then use the color picker to pick the accurate hex code. |
Hi @niels9001, I have a quick UX question for you. What's your opinion on adding a warning to the Color Picker settings page that says something along the lines of "Color Picker may be inaccurate if you use a color profile"? |
Microsoft PowerToys version
0.37.2
Running as admin
Area(s) with issue?
ColorPicker
Steps to reproduce
If your monitor has an icc profile applied, the return values differs from what is actually stored in the program that displays the color.
✔️ Expected Behavior
It seems to be a problem on screenshots in general and I guess color picker uses screenshot functionnality at some point. If I do a screenshot when having an icc profile, I have to go to photoshop and assign my icc monitor profile on the image, then convert to srgb to get the good values back.
There should be 2 options for icc profile for color picker :
The value displayed in the color picker would be first assigned in the color space of the monitor then converted to the output icc profile choosen.
As a bonus, there should be an hotkey to do this color assign/convert to images in the clipboard. So you can make a screenshot, do the color correction with hotkey directly in the clipboard, then just paste the image in the document.
❌ Actual Behavior
As an example I color picked the red "Issue-Bug" label on the right of this bug report.
The color picked value is returned as : rgb(199, 55, 23)
But in the source of the page, the correct value is : rgb(230, 0, 0)
Other Software
No response
The text was updated successfully, but these errors were encountered: