Skip to content

Commit

Permalink
Upgrade to check-spelling v0.0.24 (#36235)
Browse files Browse the repository at this point in the history
This upgrades to [v0.0.24](https://github.com/check-spelling/check-spelling/releases/tag/v0.0.24).

A number of GitHub APIs are being turned off shortly, so you need to upgrade or various uncertain outcomes will occur.

There's a new accessibility forbidden pattern:

> Do not use `(click) here` links
> For more information, see:
> * https://www.w3.org/QA/Tips/noClickHere
> * https://webaim.org/techniques/hypertext/link_text
> * https://granicus.com/blog/why-click-here-links-are-bad/
> * https://heyoka.medium.com/dont-use-click-here-f32f445d1021
```pl
(?i)(?:>|\[)(?:(?:click |)here|link|(?:read |)more)(?:</|\]\()
```

There are some minor bugs that I'm aware of and which I've fixed since this release, but I don't expect to make another release this month.

I've added a pair of patterns for includes and pragmas. My argument is that the **compiler** will _generally_ tell you if you've misspelled an include and the **linker** will _generally_ tell you if you misspell a lib.

- There's a caveat here: If your include case-insensitively matches the referenced file (but doesn't properly match it), then unless you either use a case-sensitive file system (as opposed to case-preserving) or beg clang to warn, you won't notice when you make this specific mistake -- this matters in that a couple of Windows headers (e.g. Unknwn.h) have particular case and repositories don't tend to consistently/properly write them.
  • Loading branch information
jsoref authored Dec 6, 2024
1 parent 1212ce2 commit 74a1a6e
Show file tree
Hide file tree
Showing 84 changed files with 777 additions and 509 deletions.
15 changes: 15 additions & 0 deletions .github/actions/spell-check/allow/code.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ Pbgra
WHITEONBLACK


# COUNTRIES
RUS

# FILES

AYUV
Expand Down Expand Up @@ -128,6 +131,9 @@ XBUTTONDOWN
XBUTTONUP
XDOWN

# Prefix
pcs

# User32.SYSTEM_METRICS_INDEX.cs

CLEANBOOT
Expand Down Expand Up @@ -220,12 +226,21 @@ TABLETPC
artanh
arsinh
arcosh
roundf

# Linux

dbus
anypass
github
gpg
https
ssh
ubuntu
workarounds

# For upgrade to check-spelling v0.0.24
pwa

# .NET

Expand Down
Loading

0 comments on commit 74a1a6e

Please sign in to comment.