Skip to content

Add support for assignee APIs #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Nov 30, 2018
Merged

Add support for assignee APIs #54

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ec5eaa0
initial work
joseartrivera Nov 26, 2018
c40f425
Fix some buggers
joseartrivera Nov 27, 2018
c1f5bdb
Removed default params
joseartrivera Nov 27, 2018
989f620
Start writing tests
joseartrivera Nov 27, 2018
888ed7b
add tests
joseartrivera Nov 27, 2018
4039fda
Merge remote-tracking branch 'upstream/master' into Assignees
joseartrivera Nov 27, 2018
38cddb6
Finish tests
joseartrivera Nov 27, 2018
e56de2c
add usage
joseartrivera Nov 27, 2018
8bedc4b
Fix style checks
joseartrivera Nov 27, 2018
79e2a6b
add new line
joseartrivera Nov 27, 2018
de8c266
Few more tweaks
joseartrivera Nov 28, 2018
983ede1
PR feedback
joseartrivera Nov 29, 2018
929cc66
More PR feedback
joseartrivera Nov 30, 2018
dc9793d
Delete launch.json
joseartrivera Nov 30, 2018
558d230
make list into var
joseartrivera Nov 30, 2018
282498a
Merge branch 'joriv/Assignees' of github.com:joseartrivera/PowerShell…
joseartrivera Nov 30, 2018
7dac43f
Fix lower case var name
joseartrivera Nov 30, 2018
8fd0459
Remove trailing white space
joseartrivera Nov 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions GitHubCore.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ $script:gitHubApiOrgsUrl = "https://api.github.com/orgs"

$script:defaultAcceptHeader = 'application/vnd.github.v3+json'

Set-Variable -Scope Script -Option ReadOnly -Name validBodyContainingRequestMethods -Value ('post', 'patch', 'put', 'delete')

function Invoke-GHRestMethod
{
<#
Expand Down Expand Up @@ -165,7 +167,7 @@ function Invoke-GHRestMethod
$headers['Authorization'] = "token $AccessToken"
}

if ($Method -in ('post', 'patch', 'put', 'delete'))
if ($Method -in $validBodyContainingRequestMethods)
{
$headers.Add("Content-Type", "application/json; charset=UTF-8")
}
Expand All @@ -188,7 +190,7 @@ function Invoke-GHRestMethod
$params.Add("UseBasicParsing", $true)
$params.Add("TimeoutSec", (Get-GitHubConfiguration -Name WebRequestTimeoutSec))

if ($Method -in ('post', 'put', 'patch', 'delete') -and (-not [String]::IsNullOrEmpty($Body)))
if ($Method -in $validBodyContainingRequestMethods -and (-not [String]::IsNullOrEmpty($Body)))
{
$bodyAsBytes = [System.Text.Encoding]::UTF8.GetBytes($Body)
$params.Add("Body", $bodyAsBytes)
Expand All @@ -210,7 +212,7 @@ function Invoke-GHRestMethod
if ($PSCmdlet.ShouldProcess($jobName, "Start-Job"))
{
[scriptblock]$scriptBlock = {
param($Url, $method, $Headers, $Body, $TimeoutSec, $ScriptRootPath)
param($Url, $method, $Headers, $Body, $validBodyContainingRequestMethods, $TimeoutSec, $ScriptRootPath)

# We need to "dot invoke" Helpers.ps1 and GitHubConfiguration.ps1 within
# the context of this script block since we're running in a different
Expand All @@ -227,7 +229,7 @@ function Invoke-GHRestMethod
$params.Add("UseBasicParsing", $true)
$params.Add("TimeoutSec", $TimeoutSec)

if ($Method -in ('post', 'put', 'patch', 'delete') -and (-not [String]::IsNullOrEmpty($Body)))
if ($Method -in $validBodyContainingRequestMethods -and (-not [String]::IsNullOrEmpty($Body)))
{
$bodyAsBytes = [System.Text.Encoding]::UTF8.GetBytes($Body)
$params.Add("Body", $bodyAsBytes)
Expand Down Expand Up @@ -265,7 +267,7 @@ function Invoke-GHRestMethod
}
}

$null = Start-Job -Name $jobName -ScriptBlock $scriptBlock -Arg @($url, $Method, $headers, $Body, (Get-GitHubConfiguration -Name WebRequestTimeoutSec), $PSScriptRoot)
$null = Start-Job -Name $jobName -ScriptBlock $scriptBlock -Arg @($url, $Method, $headers, $Body, $validBodyContainingRequestMethods, (Get-GitHubConfiguration -Name WebRequestTimeoutSec), $PSScriptRoot)

if ($PSCmdlet.ShouldProcess($jobName, "Wait-JobWithAnimation"))
{
Expand Down