Skip to content

Improve robustness of Get-NugetPackageDllPath to file access issues #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HowardWolosky merged 1 commit into from
Nov 14, 2018
Merged

Improve robustness of Get-NugetPackageDllPath to file access issues #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions NugetTools.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,14 @@ function Test-AssemblyIsDesiredVersion

$splitTargetVer = $DesiredVersion.Split('.')

$versionInfo = (Get-Item -Path $AssemblyPath).VersionInfo
$file = Get-Item -Path $AssemblyPath -ErrorVariable ev
if (($null -ne $ev) -and ($ev.Count -gt 0))
{
Write-Log "Problem accessing [$Path]: $($ev[0].Exception.Message)" -Level Warning
return $false
}

$versionInfo = $file.VersionInfo
$splitSourceVer = @(
$versionInfo.ProductMajorPart,
$versionInfo.ProductMinorPart,
Expand Down Expand Up @@ -300,7 +307,7 @@ function Get-NugetPackageDllPath

# First we'll check to see if the user has cached the assembly into the module's script directory
$moduleAssembly = Join-Path -Path $PSScriptRoot -ChildPath $AssemblyName
if (Test-Path -Path $moduleAssembly -PathType Leaf)
if (Test-Path -Path $moduleAssembly -PathType Leaf -ErrorAction Ignore)
{
if (Test-AssemblyIsDesiredVersion -AssemblyPath $moduleAssembly -DesiredVersion $NugetPackageVersion)
{
Expand All @@ -318,7 +325,7 @@ function Get-NugetPackageDllPath
if (-not [System.String]::IsNullOrEmpty($alternateAssemblyPath))
{
$assemblyPath = Join-Path -Path $alternateAssemblyPath -ChildPath $AssemblyName
if (Test-Path -Path $assemblyPath -PathType Leaf)
if (Test-Path -Path $assemblyPath -PathType Leaf -ErrorAction Ignore)
{
if (Test-AssemblyIsDesiredVersion -AssemblyPath $assemblyPath -DesiredVersion $NugetPackageVersion)
{
Expand All @@ -340,7 +347,7 @@ function Get-NugetPackageDllPath
else
{
$cachedAssemblyPath = Join-Path -Path $(Join-Path $script:tempAssemblyCacheDir $AssemblyPackageTailDirectory) $AssemblyName
if (Test-Path -Path $cachedAssemblyPath -PathType Leaf)
if (Test-Path -Path $cachedAssemblyPath -PathType Leaf -ErrorAction Ignore)
{
if (Test-AssemblyIsDesiredVersion -AssemblyPath $cachedAssemblyPath -DesiredVersion $NugetPackageVersion)
{
Expand All @@ -359,7 +366,7 @@ function Get-NugetPackageDllPath
Get-NugetPackage -PackageName $NugetPackageName -Version $NugetPackageVersion -TargetPath $script:tempAssemblyCacheDir -NoStatus:$NoStatus

$cachedAssemblyPath = Join-Path -Path $(Join-Path -Path $script:tempAssemblyCacheDir -ChildPath $AssemblyPackageTailDirectory) -ChildPath $AssemblyName
if (Test-Path -Path $cachedAssemblyPath -PathType Leaf)
if (Test-Path -Path $cachedAssemblyPath -PathType Leaf -ErrorAction Ignore)
{
Write-Log -Message @(
"To avoid this download delay in the future, copy the following file:",
Expand Down