Skip to content

Conversation

@chipitsine
Copy link

@chipitsine chipitsine commented Jul 13, 2018

I added commandlet for enumerating forks (I wished to get all forks for very big repo, it is not available via web gui), when doing that I also noticed that paging was working in wrong way

@msftclas
Copy link

msftclas commented Jul 14, 2018

CLA assistant check
All CLA requirements met.

@chipitsine chipitsine changed the title Paging was simply wrong, it only followed by 1 page new commandlet introduced, Get-GitHubForksForRepository, also fixed error with paging Jul 14, 2018
@chipitsine chipitsine changed the title new commandlet introduced, Get-GitHubForksForRepository, also fixed error with paging new commandlet introduced: Get-GitHubForksForRepository, also fixed error with paging Jul 14, 2018
HowardWolosky added a commit to HowardWolosky/PowerShellForGitHub that referenced this pull request Nov 13, 2018
Pull Request microsoft#31 was adding support for getting forks using
the old module structure.

I've gone ahead and added the requested functionality using
the new module layout, and additionally added support for
creating new forks, along with tests for both.
HowardWolosky added a commit that referenced this pull request Nov 13, 2018
Pull Request #31 was adding support for getting forks using
the old module structure.

I've gone ahead and added the requested functionality using
the new module layout, and additionally added support for
creating new forks, along with tests for both.
@HowardWolosky
Copy link
Contributor

Thanks so much for this submission.
As you can see, I've just taken over ownership for this module since it was abandoned, and I've been doing some general housecleaning to make it easier to consistently add new functionality. Your submission, while great, was against the old structure of the module.

I've gone ahead and added the requested functionality (querying forks), along with adding related functionality (creating a new fork), along with the associated tests and documentation.

Please do consider contributing additional changes to the module in the future now that things are all in order!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants