Skip to content

Save & restore the state of [Net.ServicePointManager]::SecurityProtocol #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HowardWolosky merged 6 commits into from
Jun 18, 2020
Merged

Save & restore the state of [Net.ServicePointManager]::SecurityProtocol #240

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
690bb8e
Save and restore the state of [Net.ServicePointManager]::SecurityProt…
giuseppecampanelli Jun 14, 2020
684104a
Merge branch 'master' into securityprotocol-save-restore-state
HowardWolosky Jun 15, 2020
fffbe13
Restore SecurityProtocol in finally clause
giuseppecampanelli Jun 16, 2020
459a9b0
Remove duplicate assignment and finally
giuseppecampanelli Jun 16, 2020
100e5bf
Update variable name
giuseppecampanelli Jun 16, 2020
31a5948
Merge branch 'master' into securityprotocol-save-restore-state
HowardWolosky Jun 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions GitHubCore.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ function Invoke-GHRestMethod
}

$NoStatus = Resolve-ParameterWithDefaultConfigurationValue -Name NoStatus -ConfigValueName DefaultNoStatus
$securityProtocol = [Net.ServicePointManager]::SecurityProtocol
Comment thread
giuseppecampanelli marked this conversation as resolved.
Outdated

try
{
Expand Down Expand Up @@ -267,6 +268,8 @@ function Invoke-GHRestMethod
}
}

$securityProtocol = [Net.ServicePointManager]::SecurityProtocol

try
{
# Disable Progress Bar in function scope during Invoke-WebRequest
Expand Down Expand Up @@ -300,6 +303,10 @@ function Invoke-GHRestMethod
$jsonConversionDepth = 20 # Seems like it should be more than sufficient
throw (ConvertTo-Json -InputObject $ex -Depth $jsonConversionDepth)
}
finally
{
[Net.ServicePointManager]::SecurityProtocol = $securityProtocol
}
}

$null = Start-Job -Name $jobName -ScriptBlock $scriptBlock -Arg @(
Expand Down Expand Up @@ -540,6 +547,13 @@ function Invoke-GHRestMethod
Set-TelemetryException -Exception $ex -ErrorBucket $errorBucket -Properties $localTelemetryProperties -NoStatus:$NoStatus
throw $newLineOutput
}
finally
{
if ($NoStatus)
Comment thread
giuseppecampanelli marked this conversation as resolved.
Outdated
{
[Net.ServicePointManager]::SecurityProtocol = $securityProtocol
}
}
}

function Invoke-GHRestMethodMultipleResult
Expand Down