Rename ConvertFrom-Markdown #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerShellCore 6 added a `ConvertFrom-Markdown` command, and this module's command therefore causes a conflict. Renaming to `ConvertFrom-GitHubMarkdown` in an effort to best identify this as being a "GitHub" method that converts Markdown, although it unfortunately does imply that it might only support "GitHub Flavored Markdown", where in fact it supports both that as well as standard. Resolves microsoft#99 - Rename ConvertFrom-Markdown
|
Will leave this up for a couple days for comment to see if anyone cares about this name change or has alternative suggestions, before I proceed with merging it in. cc: @cliffchapmanrbx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PowerShellCore 6 added a
ConvertFrom-Markdowncommand, and this module'scommand therefore causes a conflict.
Renaming to
ConvertFrom-GitHubMarkdownin an effort to best identify thisas being a "GitHub" method that converts Markdown, although it unfortunately
does imply that it might only support "GitHub Flavored Markdown", where in fact
it supports both that as well as standard.
Resolves #99 - Rename ConvertFrom-Markdown