Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

Commit

Permalink
Fix compile warnings in EngineHelper
Browse files Browse the repository at this point in the history
This fixes one set of compiler warnings, but there are many more in
other targets. This also fixes what appear to be copy-paste bugs.
  • Loading branch information
andyleejordan committed Jan 14, 2016
1 parent 499a8a5 commit 3b8679c
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions LCM/dsc/engine/EngineHelper/EngineHelper.c
Original file line number Diff line number Diff line change
Expand Up @@ -966,6 +966,9 @@ MI_Boolean InstanceContainsProperty(_In_ MI_Instance* instance,
return MI_TRUE;
}

MI_Result ExpandPath(_In_z_ const MI_Char * pathIn,
_Outptr_result_maybenull_z_ MI_Char **expandedPath,
_Outptr_result_maybenull_ MI_Instance **cimErrorDetails);

/*Function to validate if a directory has files.*/
MI_Result ValidateDirectoryHasFiles(_In_z_ const MI_Char* directoryName)
Expand Down Expand Up @@ -1122,7 +1125,7 @@ MI_Result ShouldUseV1Protocol(
MI_Value value;
MI_Uint32 flags;

result = result = DSC_MI_Instance_GetElement((MI_Instance*)g_metaConfig, MSFT_DSCMetaConfiguration_ConfigurationID, &value, NULL, &flags, NULL);
result = DSC_MI_Instance_GetElement((MI_Instance*)g_metaConfig, MSFT_DSCMetaConfiguration_ConfigurationID, &value, NULL, &flags, NULL);
if (result == MI_RESULT_OK && !(flags & MI_FLAG_NULL) && (Tcscasecmp(MI_T(""), value.string) != 0))
{
*isV1MetaConfig = MI_TRUE;
Expand All @@ -1136,12 +1139,14 @@ MI_Result GetAgentInformation(
_Inout_ MI_Instance** registrationPayload)
{
MI_Application miApp = MI_APPLICATION_NULL;
MI_Boolean applicationInitialized = MI_FALSE;
// NetworkInformation networkInformation = { 0 };
MI_Result result = MI_RESULT_OK;
/* TODO: used in below implementation
MI_Boolean applicationInitialized = MI_FALSE;
MI_Value value;
MI_Char *ipAddress = NULL;
MI_Uint32 count = 0;
*/
if (g_metaConfig == NULL)
{
assert(1);
Expand All @@ -1152,9 +1157,9 @@ MI_Result GetAgentInformation(

result = DSC_MI_Application_NewInstance(&miApp, AGENT_REGISTRATION_CLASS, NULL, registrationPayload);
EH_CheckResult(result);
/* TODO: implement these
applicationInitialized = MI_TRUE;
/* TODO: implement these
// Set IPAddress
result = GetIPAndMacAddresses(lcmContext, &networkInformation);
// TODO : TO be uncommented afer Jane's fix for MSFT:2004179 FIs to REL
Expand Down Expand Up @@ -1207,7 +1212,7 @@ MI_Result GetAgentInformation(
*/
EH_UNWIND:
MI_Application_Close(&miApp);
applicationInitialized = MI_FALSE;
/* applicationInitialized = MI_FALSE; */
return result;
}

Expand Down

0 comments on commit 3b8679c

Please sign in to comment.