-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Informa (Independent Publisher) #3492
base: dev
Are you sure you want to change the base?
Informa (Independent Publisher) #3492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@microsoft-github-policy-service agree company="Axazure"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @marpedroche,
Kindly go through the below documentation to submit the Independent publisher connector. There many folders in your PR, they are not required.
https://learn.microsoft.com/en-us/connectors/custom-connectors/certification-submission-ip
@vmanoharas The 'img' folder is used to store the image used in the README file. In my first connector, screenshots were necessary to verify if the connector worked correctly. Please let me know if you don't need these screenshots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @marpedroche,
Kindly resolve the review comments.
Additionally, all the screen shots should be attached in the conversation, please remove from the files section. Please follow the Independent Publisher documentation as mentioned in the below document.
https://learn.microsoft.com/en-us/connectors/custom-connectors/certification-submission-ip
@@ -0,0 +1,28 @@ | |||
# Informa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update readme.md file as per link in the below template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refer the above link and make sure that that all the required sections are added into the readme.md file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @marpedroche
Most of the files are in Spanish it seems, kindly submit your files in English, our team will convert your connector files into other languages.
independent-publisher-connectors/Informa/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
independent-publisher-connectors/Informa/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
independent-publisher-connectors/Informa/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
"operationId": "InformaGet-predictive", | ||
"parameters": [ | ||
{ | ||
"name": "denominacion", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly correct the spelling "denominacion"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I should use 'denominacion' which is what the API expects. Is in spanish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly post your connector in English, this will be translated to other languages later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API requires specific parameters, as indicated. This is a Spanish solution that provides public information about Spanish companies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the public documentation link mentioned below, your connector, titles, descriptions, operations, summaries everything should be in English.
independent-publisher-connectors/Informa/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
independent-publisher-connectors/Informa/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
"description": "Username", | ||
"title": "Username" | ||
}, | ||
"formato": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly correct the spelling "formato"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I should use 'formato' which is what the API expects. Is in spanish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly post your connector in English, this will be translated to other languages later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API requires specific parameters, as indicated. This is a Spanish solution that provides public information about Spanish companies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the public documentation link mentioned below, your connector, titles, descriptions, operations, summaries everything should be in English.
"informacionComercial": { | ||
"type": "object", | ||
"properties": { | ||
"identificacion": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct the spelling "identificacion"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I should use 'formato' which is what the API expects. Is in spanish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly post your connector in English, this will be translated to other languages later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API requires specific parameters, as indicated. This is a Spanish solution that provides public information about Spanish companies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The string is not formato, it is "identificacion". As per the public documentation link mentioned below, your connector, titles, descriptions, operations, summaries everything should be in English.
}, | ||
"description": "datosGenerales" | ||
}, | ||
"direcciones": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct the spelling "direcciones"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I should use 'formato' which is what the API expects. Is in spanish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly post your connector in English, this will be translated to other languages later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API requires specific parameters, as indicated. This is a Spanish solution that provides public information about Spanish companies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The string is not formato, it is "direcciones". As per the public documentation link mentioned below, your connector, titles, descriptions, operations, summaries everything should be in English.
independent-publisher-connectors/Informa/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
Hello @marpedroche, I am following up on the above review comments, kindly resolve above review comments. |
@vmanoharas 'PowerUser365blog' is my personal account. I think VS is mixing up the user accounts. Sorry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @marpendroche,
Kindly submit your connector in English, this will be translated to other languages to other languages later after certified.
"operationId": "InformaGet-predictive", | ||
"parameters": [ | ||
{ | ||
"name": "denominacion", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly post your connector in English, this will be translated to other languages later.
"description": "Username", | ||
"title": "Username" | ||
}, | ||
"formato": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly post your connector in English, this will be translated to other languages later.
"informacionComercial": { | ||
"type": "object", | ||
"properties": { | ||
"identificacion": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly post your connector in English, this will be translated to other languages later.
}, | ||
"description": "datosGenerales" | ||
}, | ||
"direcciones": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly post your connector in English, this will be translated to other languages later.
Hello @marpedroche, Please check this documentation, everything in your artifacts should be in English. Additionally, must be free of grammatical and spelling errors. |
Hello @vmanoharas, While the connector's name, descriptions, and display names are in English, the internal API parameters are in Spanish. Unfortunately, I cannot make further changes, as this is not my API, and I don't have the ability to request modifications. |
Hello @marpedroche, Kindly check from your end and modify, meanwhile I will discuss internally and get back to you. Unfortunately other language connectors will not be certified as our internal localization team will convert to other languages after certified. |
When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.
apiDefinition.swagger.json
, by runningpaconn validate
command.apiProperties.json
has a valid brand color and doesn't use an invalid brand color,#007ee5
or#ffffff
. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process: